Initial implementation for lazy compound assignment operators

Initial implementation for lazy compound assignment operators

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4dcb9b61964613d47a73b0e5058ec963a07e1c73

[Brian Wilkerson, 2016-08-02 14:50:39]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-08-02 14:50:40]

This is behind a flag, but the flag has not yet been exposed in any
user-accessible way. There are no shared tests, so there's a good chance this
will need work before being exposed.

[scheglov, 2016-08-02 15:25:03]

LGTM

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:160: operatorType !=
TokenType.BAR_BAR_EQ &&
Should we resolve &&= and ||= to corresponding & and | operators?

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:48: // exists or the "field" is
actually a getter/setter.
Make this a documentation comment?

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:934: // according to our current
criteria.
Make this a documentation comment?

[scheglov, 2016-08-02 15:33:23]

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:160: operatorType !=
TokenType.BAR_BAR_EQ &&
On 2016/08/02 15:25:03, scheglov wrote:
> Should we resolve &&= and ||= to corresponding & and | operators?

Actually, never-mind.
Operators && and || are not user definable.

[Brian Wilkerson, 2016-08-02 15:33:53]

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:48: // exists or the "field" is
actually a getter/setter.
> Make this a documentation comment?

Or delete it. I didn't add this comment, it was moved here by the sorter. In the
previous version it was on line 56, but there's no way of knowing where it was
originally (it seems unlikely that someone would write a doc comment and switch
the comment kind part way through).

https://codereview.chromium.org/2199323002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:934: // according to our current
criteria.
I didn't write this comment either, it was also moved here by the sorter. In the
previous version it was on line 936, but probably didn't start there.

[Brian Wilkerson, 2016-08-02 16:16:20]

Description was changed from

==========
Initial implementation for lazy compound assignment operators
==========

to

==========
Initial implementation for lazy compound assignment operators

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4dcb9b61964613d47a73b0e5058ec963a07e1c73
==========

[Brian Wilkerson, 2016-08-02 16:16:21]

Committed patchset #1 (id:1) manually as
4dcb9b61964613d47a73b0e5058ec963a07e1c73 (presubmit successful).