pkg/analyzer/lib/src/generated/resolver.dart - Issue 2199323002: Initial implementation for lazy compound assignment operators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 2199323002: Initial implementation for lazy compound assignment operators (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 9b3b7fbb74a296f054288149846758798b35d9f6..afa7ccec98ee9c48746663cc1c1a9893c0b0b541 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -3434,7 +3434,10 @@ class ExitDetector extends GeneralizingAstVisitor<bool> {

if (_nodeExits(leftHandSide)) {

return true;

}

- if (node.operator.type == TokenType.QUESTION_QUESTION_EQ) {

+ TokenType operatorType = node.operator.type;

+ if (operatorType == TokenType.AMPERSAND_AMPERSAND_EQ ||

+ operatorType == TokenType.BAR_BAR_EQ ||

+ operatorType == TokenType.QUESTION_QUESTION_EQ) {

return false;

}

if (leftHandSide is PropertyAccess &&