Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2199313002: [Mac] Only enable the CFBundleBlocker in the browser process. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Only enable the CFBundleBlocker in the browser process. In child processes, which are sandboxed in most cases, the sandbox will prevent access to the filesystem locations where the potentially blocked bundles are stored. Furthermore, on macOS 10.11 and higher, the Google Chrome build is codesigned in such a way where bundle loading is blocked by SIP. This reduces some of the "triggered DYLD shared region unnest for map" messages. BUG=428858 R=mark@chromium.org Committed: https://crrev.com/65e732d3b4dc595512b731143fd49d372acc1a87 Cr-Commit-Position: refs/heads/master@{#409244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Robert Sesek
4 years, 4 months ago (2016-08-02 15:14:06 UTC) #3
Mark Mentovai
LGTM
4 years, 4 months ago (2016-08-02 15:45:25 UTC) #6
Robert Sesek
+thakis for //chrome OWNERS
4 years, 4 months ago (2016-08-02 18:02:53 UTC) #8
Nico
value-adding lgtm
4 years, 4 months ago (2016-08-02 18:06:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199313002/1
4 years, 4 months ago (2016-08-02 18:07:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 18:13:38 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65e732d3b4dc595512b731143fd49d372acc1a87 Cr-Commit-Position: refs/heads/master@{#409244}
4 years, 4 months ago (2016-08-02 18:15:55 UTC) #14
Robert Sesek
4 years, 4 months ago (2016-08-05 17:30:56 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2218163002/ by rsesek@chromium.org.

The reason for reverting is: Speculative revert for perf regression.

BUG=https://crbug.com/634917.

Powered by Google App Engine
This is Rietveld 408576698