Issue 219923005: MIPS: Fix PrepareKeyedOperand on MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219923005: MIPS: Fix PrepareKeyedOperand on MIPS. (Closed)

Created:
6 years, 8 months ago by palfia

Modified:
6 years, 8 months ago

Reviewers:
Dmitry Lomov (no reviews), Paul Lind, danno, kisg, kilvadyb, dusmil

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix PrepareKeyedOperand on MIPS. Port r20363 (235f866c) Original commit message: When additional_offset is specified, the 'key' operand can be negative and still pass the bounds check. Therefore, when converting key from Smi, arithmetic and not logical shift must be used. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=20370

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

palfia

6 years, 8 months ago (2014-03-31 22:51:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20370 (presubmit successful).

Expand Messages | Collapse Messages