src/mips/lithium-codegen-mips.cc - Issue 219923005: MIPS: Fix PrepareKeyedOperand on MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 219923005: MIPS: Fix PrepareKeyedOperand on MIPS. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/lithium-codegen-mips.cc

diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc

index e6f52d84b707ef82d3385eddea892525039b744d..57d13fb0e8e55ced2047e0003a1d2889c35d6cf4 100644

--- a/src/mips/lithium-codegen-mips.cc

+++ b/src/mips/lithium-codegen-mips.cc

@@ -3259,7 +3259,8 @@ MemOperand LCodeGen::PrepareKeyedOperand(Register key,

__ Addu(scratch0(), scratch0(), Operand(base_offset));

} else {

ASSERT_EQ(-1, shift_size);

- __ srl(scratch0(), key, 1);

+ // Key can be negative, so using sra here.

+ __ sra(scratch0(), key, 1);

__ Addu(scratch0(), scratch0(), Operand(base_offset));

}

__ Addu(scratch0(), base, scratch0());

« no previous file with comments | « no previous file | no next file » | no next file with comments »