Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219903002: Revert 170347 "Convert HTMLFrameOwnerElement and FocusController..." (Closed)

Created:
6 years, 8 months ago by myuan
Modified:
6 years, 8 months ago
Reviewers:
kenrb
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, Nils Barth (inactive), caseq+blink_chromium.org, kojih, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, Inactive, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, kouhei+bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org
Visibility:
Public.

Description

Revert 170347 "Convert HTMLFrameOwnerElement and FocusController..." > Convert HTMLFrameOwnerElement and FocusController to use Frame. > > HTMLFrameOwnerElement and FocusController need to be able to hold > pointers to RemoteFrames as well as LocalFrames. The appropriate > members are converted from LocalFrame to the base class Frame in order > to support this. > > BUG=346764 > R=dcheng@chromium.org, eseidel@chromium.org > > Review URL: https://codereview.chromium.org/189573002 TBR=kenrb@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -209 lines) Patch
M Source/bindings/v8/BindingSecurity.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/v8/BindingSecurity.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Frame.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/frame/Frame.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 3 chunks +8 lines, -5 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 3 chunks +18 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/page/FocusController.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/FocusController.cpp View 10 chunks +18 lines, -25 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/testing/MockPagePopupDriver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/web/SpellCheckerClientImpl.cpp View 3 chunks +8 lines, -12 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 26 chunks +48 lines, -62 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
myuan
6 years, 8 months ago (2014-03-31 19:27:24 UTC) #1
myuan
6 years, 8 months ago (2014-03-31 19:29:40 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r170479.

Powered by Google App Engine
This is Rietveld 408576698