Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: include/core/SkLights.h

Issue 2198933002: Making a sample for shadow maps for more intensive development (Closed) Base URL: https://skia.googlesource.com/skia@shadow-gm
Patch Set: Removed setDir() and re-added resizing shadow maps Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/core/SkLights.h
diff --git a/include/core/SkLights.h b/include/core/SkLights.h
index 52e60c71a07a5fe3cae5f441f58e858617490251..adef39a6c4a2748ce8fcb8c171295dcebf4f3e9d 100644
--- a/include/core/SkLights.h
+++ b/include/core/SkLights.h
@@ -63,8 +63,8 @@ public:
fShadowMap = std::move(shadowMap);
}
robertphillips 2016/08/03 18:47:47 For better or for worse, Skia doesn't usually retu
vjiaoblack 2016/08/04 13:36:21 Ah. That must've been why this change was made,
- SkImage* getShadowMap() const {
- return fShadowMap.get();
+ sk_sp<SkImage> getShadowMap() const {
+ return fShadowMap;
}
Light& operator= (const Light& b) {

Powered by Google App Engine
This is Rietveld 408576698