Making a sample for shadow maps for more intensive development

include/core/SkLights.h

 
 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkLights_DEFINED
 #define SkLights_DEFINED
@@ skipping 44 matching lines @@
         LightType type() const { return fType; }
         const SkColor3f& color() const { return fColor; }
         const SkVector3& dir() const { 
             SkASSERT(kAmbient_LightType != fType);
             return fDirection; 
         }
 
         void setShadowMap(sk_sp<SkImage> shadowMap) {
             fShadowMap = std::move(shadowMap);
         }
 

[robertphillips, 2016/08/03 18:47:47]

For better or for worse, Skia doesn't usually return sk_sp from accessors.

[vjiaoblack, 2016/08/04 13:36:21]

Ah. 

That must've been why this change was made, then.

(I don't remember it being just an SkImage*.)

I'll make the changes in my code.

-        SkImage* getShadowMap() const {
-            return fShadowMap.get();
+        sk_sp<SkImage> getShadowMap() const {
+            return fShadowMap;
         }
 
         Light& operator= (const Light& b) {
             if (this == &b) {
                 return *this;
             }
 
             fColor = b.fColor;
             fType = b.fType;
             fDirection = b.fDirection;
@@ skipping 47 matching lines @@
 
 private:
     SkLights() {}
 
     SkTArray<Light> fLights;
 
     typedef SkRefCnt INHERITED;
 };
 
 #endif