Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2198373002: Avoid copying NV12 GL_TEXTURE_EXTERNAL_OES textures for use with skia. (Closed)

Created:
4 years, 4 months ago by jbauman
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Avoid copying NV12 GL_TEXTURE_EXTERNAL_OES textures for use with skia. Skia can now handle reading from GL_TEXTURE_EXTERNAL_OES textures. It'll immediately do a conversion from YUV to RGB and release the input texture, so we don't need to worry about the texture lifetime. BUG=625900, 505026 Review-Url: https://codereview.chromium.org/2126053002 Cr-Commit-Position: refs/heads/master@{#404042} (cherry picked from commit 48ec0365657930e8428945f8090432b05f42f14e) Committed: https://chromium.googlesource.com/chromium/src/+/8d2e0414e4d63b63a056b39847d95b06334d08cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/renderers/skcanvas_video_renderer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
4 years, 4 months ago (2016-08-01 22:15:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d2e0414e4d63b63a056b39847d95b06334d08cb (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698