Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2126053002: Avoid copying NV12 GL_TEXTURE_EXTERNAL_OES textures for use with skia. (Closed)

Created:
4 years, 5 months ago by jbauman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid copying NV12 GL_TEXTURE_EXTERNAL_OES textures for use with skia. Skia can now handle reading from GL_TEXTURE_EXTERNAL_OES textures. It'll immediately do a conversion from YUV to RGB and release the input texture, so we don't need to worry about the texture lifetime. BUG=625900, 505026 Committed: https://crrev.com/48ec0365657930e8428945f8090432b05f42f14e Cr-Commit-Position: refs/heads/master@{#404042}

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/renderers/skcanvas_video_renderer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
jbauman
4 years, 5 months ago (2016-07-07 00:52:19 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 5 months ago (2016-07-07 01:10:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126053002/20001
4 years, 5 months ago (2016-07-07 01:17:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 02:44:21 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 02:44:35 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/48ec0365657930e8428945f8090432b05f42f14e Cr-Commit-Position: refs/heads/master@{#404042}
4 years, 5 months ago (2016-07-07 02:46:08 UTC) #11
Corentin Wallez
4 years, 5 months ago (2016-07-07 17:51:45 UTC) #12
Message was sent while issue was closed.
On 2016/07/07 at 02:46:08, commit-bot wrote:
> Patchset 2 (id:??) landed as
https://crrev.com/48ec0365657930e8428945f8090432b05f42f14e
> Cr-Commit-Position: refs/heads/master@{#404042}

This CL might be the one making
WebglConformance.conformance_textures_misc_texture_npot_video flaky on
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NV...

John, can you take a look?

Powered by Google App Engine
This is Rietveld 408576698