components/spellcheck/renderer/spellcheck_multilingual_unittest.cc - Issue 2198143002: Componentize spellcheck [3]: move renderer/ files to component.

Unified Diff: components/spellcheck/renderer/spellcheck_multilingual_unittest.cc

Issue 2198143002: Componentize spellcheck [3]: move renderer/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix formatting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/spellcheck/renderer/spellcheck_language.cc ('k') | components/spellcheck/renderer/spellcheck_provider.h » ('j') | components/spellcheck/renderer/spellcheck_provider_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/spellcheck/renderer/spellcheck_multilingual_unittest.cc

diff --git a/chrome/renderer/spellchecker/spellcheck_multilingual_unittest.cc b/components/spellcheck/renderer/spellcheck_multilingual_unittest.cc

similarity index 97%

rename from chrome/renderer/spellchecker/spellcheck_multilingual_unittest.cc

rename to components/spellcheck/renderer/spellcheck_multilingual_unittest.cc

index 37eaebad6c8a726fceaa616bc4d01cc2d6921b0c..5d33bc3fe36563c68f5725d86f5194f82c3efb61 100644

--- a/chrome/renderer/spellchecker/spellcheck_multilingual_unittest.cc

+++ b/components/spellcheck/renderer/spellcheck_multilingual_unittest.cc

@@ -13,10 +13,11 @@

#include "base/strings/string_split.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/renderer/spellchecker/spellcheck.h"

-#include "chrome/renderer/spellchecker/spellcheck_provider_test.h"

#include "components/spellcheck/common/spellcheck_common.h"

#include "components/spellcheck/common/spellcheck_result.h"

+#include "components/spellcheck/renderer/spellcheck.h"

+#include "components/spellcheck/renderer/spellcheck_provider_test.h"

+#include "components/test_runner/test_common.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "third_party/WebKit/public/platform/WebString.h"

#include "third_party/WebKit/public/platform/WebVector.h"

@@ -46,7 +47,7 @@ base::FilePath GetHunspellDirectory() {

class MultilingualSpellCheckTest : public testing::Test {

public:

- MultilingualSpellCheckTest() {}

+ MultilingualSpellCheckTest() { test_runner::EnsureBlinkInitialized(); }

groby-ooo-7-16 2016/08/03 17:31:54 Why does this need blink initialized?

timvolodine 2016/08/03 19:12:30 if I don't do that I get a crash stack with someth

void ReinitializeSpellCheck(const std::string& unsplit_languages) {

spellcheck_ = new SpellCheck();