Componentize spellcheck [3]: move renderer/ files to component.

components/spellcheck/renderer/spellcheck_multilingual_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
-#include "chrome/renderer/spellchecker/spellcheck.h"
-#include "chrome/renderer/spellchecker/spellcheck_provider_test.h"
 #include "components/spellcheck/common/spellcheck_common.h"
 #include "components/spellcheck/common/spellcheck_result.h"
+#include "components/spellcheck/renderer/spellcheck.h"
+#include "components/spellcheck/renderer/spellcheck_provider_test.h"
+#include "components/test_runner/test_common.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/web/WebTextCheckingResult.h"
 
 namespace {
 
 struct SpellcheckTestCase {
   // A string of text for checking.
   const wchar_t* input;
   // The position and the length of the first misspelled word, if any.
   int expected_misspelling_start;
   int expected_misspelling_length;
 };
 
 base::FilePath GetHunspellDirectory() {
   base::FilePath hunspell_directory;
   if (!PathService::Get(base::DIR_SOURCE_ROOT, &hunspell_directory))
     return base::FilePath();
 
   hunspell_directory = hunspell_directory.AppendASCII("third_party");
   hunspell_directory = hunspell_directory.AppendASCII("hunspell_dictionaries");
   return hunspell_directory;
 }
 
 }  // namespace
 
 class MultilingualSpellCheckTest : public testing::Test {
  public:
-  MultilingualSpellCheckTest() {}
+  MultilingualSpellCheckTest() { test_runner::EnsureBlinkInitialized(); }

[groby-ooo-7-16, 2016/08/03 17:31:54]

Why does this need blink initialized?

[timvolodine, 2016/08/03 19:12:30]

if I don't do that I get a crash stack with something like:
[ RUN      ] SpellCheckTest.CreateTextCheckingResultsAddsGrammarMarkers
ASSERTION FAILED: s_initialized
../../third_party/WebKit/Source/wtf/allocator/Partitions.h(53) : static
WTF::PartitionRootGeneric *WTF::Partitions::bufferPartition()

(this is why many bots in patch #5 were red.)

it looks like the explicit init is typically needed for tests in components, we
have a couple of component tests doing a similar thing:
https://cs.chromium.org/search/?q=%22test_runner::EnsureBlinkInitialized();%2...

 
   void ReinitializeSpellCheck(const std::string& unsplit_languages) {
     spellcheck_ = new SpellCheck();
     provider_.reset(new TestingSpellCheckProvider(spellcheck_));
     InitializeSpellCheck(unsplit_languages);
   }
 
   void InitializeSpellCheck(const std::string& unsplit_languages) {
     base::FilePath hunspell_directory = GetHunspellDirectory();
     EXPECT_FALSE(hunspell_directory.empty());
@@ skipping 187 matching lines @@
         base::WideToUTF16(kTestCases[i].expected_suggestions),
         base::string16(1, ','), base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
 
     EXPECT_EQ(expected_suggestions.size(), suggestions.size());
     for (size_t j = 0;
          j < std::min(expected_suggestions.size(), suggestions.size()); j++) {
       EXPECT_EQ(expected_suggestions[j], base::string16(suggestions[j]));
     }
   }
 }