chrome/test/BUILD.gn - Issue 2198143002: Componentize spellcheck [3]: move renderer/ files to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 2198143002: Componentize spellcheck [3]: move renderer/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix formatting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/spellchecker/spelling_engine.h ('k') | chrome/test/base/chrome_render_view_test.cc » ('j') | components/spellcheck/renderer/spellcheck_multilingual_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 30cae7ce282a283193452368cb8cc0e6b14f9890..cd1cbf0cbbed4da7d4cce59ebb56329d0624375c 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -1913,22 +1913,12 @@ test("unit_tests") {

".",

"//chrome")

}

if (enable_spellcheck) {

sources += rebase_path(

chrome_tests_unit_gypi_values.chrome_unit_tests_spellchecker_sources,

".",

"//chrome")

- if (is_mac && !is_ios) {

- deps += [ "//third_party/hunspell" ]

- }

- if (is_android) {

- sources -= [

- "../renderer/spellchecker/spellcheck_multilingual_unittest.cc",

- "../renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc",

- "../renderer/spellchecker/spellcheck_unittest.cc",

- ]

- }

}

if (enable_one_click_signin) {

@@ -2153,8 +2143,6 @@ test("unit_tests") {

"../browser/ui/tests/ui_gfx_image_unittest.cc",

# This tests Chrome's spellchecker which Mac doesn't use.

- "../renderer/spellchecker/spellcheck_multilingual_unittest.cc",

- "../renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc",

"../tools/convert_dict/convert_dict_unittest.cc",

]