Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2198133002:
[turbofan] Minor refactoring. (Closed)
|
Created:
4 years, 4 months ago by Franzi Modified:
4 years, 4 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@RefactorCodeStubs Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Minor refactoring.
Use CodeStubAssembler functions instead of LoadObjectField with
the offset.
BUG=
Committed: https://crrev.com/26c902ec8c293e0c793182e0c5681f0df24c51d4
Cr-Commit-Position: refs/heads/master@{#38229}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 19 (13 generated)
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
franzih@chromium.org changed reviewers: + bmeurer@chromium.org
Another small fix in code-stubs. Can you have a look?
The CQ bit was checked by bmeurer@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2200713002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by franzih@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2198133002/#ps1 (title: "None")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Minor refactoring. Use CodeStubAssembler functions instead of LoadObjectField with the offset. BUG= ========== to ========== [turbofan] Minor refactoring. Use CodeStubAssembler functions instead of LoadObjectField with the offset. BUG= Committed: https://crrev.com/26c902ec8c293e0c793182e0c5681f0df24c51d4 Cr-Commit-Position: refs/heads/master@{#38229} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/26c902ec8c293e0c793182e0c5681f0df24c51d4 Cr-Commit-Position: refs/heads/master@{#38229} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
