[turbofan] Minor refactoring.

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/bootstrapper.h"
 #include "src/code-factory.h"
@@ skipping 504 matching lines @@
     assembler->StoreNoWriteBarrier(                                         \
         MachineRepresentation::kTagged, map,                                \
         assembler->HeapConstant(isolate()->factory()->type##_map()));       \
     assembler->Return(result);                                              \
   }
 SIMD128_TYPES(SIMD128_GEN_ASM)
 #undef SIMD128_GEN_ASM
 
 void StringLengthStub::GenerateAssembly(CodeStubAssembler* assembler) const {
   compiler::Node* value = assembler->Parameter(0);
-  compiler::Node* string =
-      assembler->LoadObjectField(value, JSValue::kValueOffset);
-  compiler::Node* result =
-      assembler->LoadObjectField(string, String::kLengthOffset);
+  compiler::Node* string = assembler->LoadJSValueValue(value);
+  compiler::Node* result = assembler->LoadStringLength(string);
   assembler->Return(result);
 }
 
 // static
 compiler::Node* AddStub::Generate(CodeStubAssembler* assembler,
                                   compiler::Node* left, compiler::Node* right,
                                   compiler::Node* context) {
   typedef CodeStubAssembler::Label Label;
   typedef compiler::Node Node;
   typedef CodeStubAssembler::Variable Variable;
@@ skipping 2851 matching lines @@
     assembler->Branch(assembler->Word32Equal(
                           assembler->Word32And(both_instance_types,
                                                assembler->Int32Constant(
                                                    kBothSeqOneByteStringMask)),
                           assembler->Int32Constant(kBothSeqOneByteStringTag)),
                       &if_bothonebyteseqstrings, &if_notbothonebyteseqstrings);
 
     assembler->Bind(&if_bothonebyteseqstrings);
     {
       // Load the length of {lhs} and {rhs}.
-      Node* lhs_length = assembler->LoadObjectField(lhs, String::kLengthOffset);
-      Node* rhs_length = assembler->LoadObjectField(rhs, String::kLengthOffset);
+      Node* lhs_length = assembler->LoadStringLength(lhs);
+      Node* rhs_length = assembler->LoadStringLength(rhs);
 
       // Determine the minimum length.
       Node* length = assembler->SmiMin(lhs_length, rhs_length);
 
       // Compute the effective offset of the first character.
       Node* begin = assembler->IntPtrConstant(SeqOneByteString::kHeaderSize -
                                               kHeapObjectTag);
 
       // Compute the first offset after the string from the length.
       Node* end = assembler->IntPtrAdd(begin, assembler->SmiUntag(length));
@@ skipping 150 matching lines @@
   assembler->Branch(assembler->WordEqual(lhs, rhs), &if_same, &if_notsame);
 
   assembler->Bind(&if_same);
   assembler->Goto(&if_equal);
 
   assembler->Bind(&if_notsame);
   {
     // The {lhs} and {rhs} don't refer to the exact same String object.
 
     // Load the length of {lhs} and {rhs}.
-    Node* lhs_length = assembler->LoadObjectField(lhs, String::kLengthOffset);
-    Node* rhs_length = assembler->LoadObjectField(rhs, String::kLengthOffset);
+    Node* lhs_length = assembler->LoadStringLength(lhs);
+    Node* rhs_length = assembler->LoadStringLength(rhs);
 
     // Check if the lengths of {lhs} and {rhs} are equal.
     Label if_lengthisequal(assembler), if_lengthisnotequal(assembler);
     assembler->Branch(assembler->WordEqual(lhs_length, rhs_length),
                       &if_lengthisequal, &if_lengthisnotequal);
 
     assembler->Bind(&if_lengthisequal);
     {
       // Load instance types of {lhs} and {rhs}.
       Node* lhs_instance_type = assembler->LoadInstanceType(lhs);
@@ skipping 1461 matching lines @@
   if (type->Is(Type::UntaggedPointer())) {
     return Representation::External();
   }
 
   DCHECK(!type->Is(Type::Untagged()));
   return Representation::Tagged();
 }
 
 }  // namespace internal
 }  // namespace v8