RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

This tag was removed in https://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.

LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.

BUG=632457, 627816
Committed: https://crrev.com/7a4e83b57886f79649c47c8f3476ac961f291d07
Cr-Commit-Position: refs/heads/master@{#409167}

[hbos_chromium, 2016-08-01 16:14:42]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 16:14:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hbos_chromium, 2016-08-01 16:15:30]

Description was changed from

==========
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

This tag was removed in https://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.

LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.

BUG=632457
==========

to

==========
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

This tag was removed in https://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.

LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.

BUG=632457, 627816
==========

[hbos_chromium, 2016-08-01 16:16:56]

hbos@chromium.org changed reviewers:
+ foolip@chromium.org, guidou@chromium.org

[hbos_chromium, 2016-08-01 16:16:56]

Please take a look, foolip and guidou.

[foolip, 2016-08-01 16:42:30]

lgtm, but can you diff the generated code to make sure there's no difference in
how the first argument is handled that slipped through testing?

Oh, and a test that uses something silly as the second argument would be good,
for when I later come around and try to remove [LegacyInterfaceTypeChecking] but
forgot about this issue.

[Guido Urdaneta, 2016-08-01 17:03:22]

lgtm % foolip's comments

[commit-bot: I haz the power, 2016-08-01 18:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 18:00:29]

Dry run: This issue passed the CQ dry run.

[hbos_chromium, 2016-08-02 08:54:53]

On 2016/08/01 16:42:30, foolip wrote:
> lgtm, but can you diff the generated code to make sure there's no difference
in
> how the first argument is handled that slipped through testing?
> 
> Oh, and a test that uses something silly as the second argument would be good,
> for when I later come around and try to remove [LegacyInterfaceTypeChecking]
but
> forgot about this issue.

I diffed the generated code and it looks right :)

The switch case for choosing which function to call is identical, the only
difference is without LegacyInterfaceTypeChecking it throws an exception if the
second argument could not be cast to a MediaStreamTrack*, and with it the check
is gone so it continues the call with a null selector.

[hbos_chromium, 2016-08-02 08:55:13]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2016-08-02 08:55:13]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2198123002/#ps20001
(title: "Silly argument test")

[commit-bot: I haz the power, 2016-08-02 08:55:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 10:38:33]

Description was changed from

==========
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

This tag was removed in https://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.

LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.

BUG=632457, 627816
==========

to

==========
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

This tag was removed in https://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.

LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.

BUG=632457, 627816
==========

[commit-bot: I haz the power, 2016-08-02 10:38:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 10:39:47]

Description was changed from

==========
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

This tag was removed in https://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.

LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.

BUG=632457, 627816
==========

to

==========
RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking.

This tag was removed in https://codereview.chromium.org/2156063002/
which caused a regression (crbug.com/632457). This CL re-adds it to
solve that regression. The generated bindings code is able to
call the correct overloaded getStats function with or without it.

LegacyInterfaceTypeChecking means any (nonsense) argument can be passed
as the second parameter and if its not a MediaStreamTrack it is
interpreted as null. This was something adapter.js relied on.

BUG=632457, 627816

Committed: https://crrev.com/7a4e83b57886f79649c47c8f3476ac961f291d07
Cr-Commit-Position: refs/heads/master@{#409167}
==========

[commit-bot: I haz the power, 2016-08-02 10:39:48]

Patchset 2 (id:??) landed as
https://crrev.com/7a4e83b57886f79649c47c8f3476ac961f291d07
Cr-Commit-Position: refs/heads/master@{#409167}