Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2198123002: RTCPeerConnection.getStats gets LegacyInterfaceTypeChecking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Silly argument test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 // TODO(guidou): There should be no mediaConstraints argument. 101 // TODO(guidou): There should be no mediaConstraints argument.
102 [CallWith=ScriptState] Promise<void> createAnswer(RTCSessionDescriptionCallb ack successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Di ctionary mediaConstraints); 102 [CallWith=ScriptState] Promise<void> createAnswer(RTCSessionDescriptionCallb ack successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Di ctionary mediaConstraints);
103 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description, VoidCallback successCallback, [Default=Undefined] optional R TCPeerConnectionErrorCallback failureCallback); 103 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti onInit description, VoidCallback successCallback, [Default=Undefined] optional R TCPeerConnectionErrorCallback failureCallback);
104 // TODO(guidou): The failureCallback argument should be non-optional. 104 // TODO(guidou): The failureCallback argument should be non-optional.
105 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback); 105 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);
106 [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidateLegacy] Pro mise<void> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate, V oidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback); 106 [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidateLegacy] Pro mise<void> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate, V oidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback);
107 107
108 // TODO(guidou): The selector argument should the first (nullable, 108 // TODO(guidou): The selector argument should the first (nullable,
109 // non-optional) argument, and there should be a third failureCallback 109 // non-optional) argument, and there should be a third failureCallback
110 // argument. 110 // argument.
111 [CallWith=ScriptState] Promise<void> getStats(RTCStatsCallback successCallba ck, optional MediaStreamTrack? selector); 111 [CallWith=ScriptState, LegacyInterfaceTypeChecking] Promise<void> getStats(R TCStatsCallback successCallback, optional MediaStreamTrack? selector);
112 [CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats] Promise< RTCStatsReport> getStats(optional MediaStreamTrack? selector); 112 [CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats] Promise< RTCStatsReport> getStats(optional MediaStreamTrack? selector);
113 113
114 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api 114 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api
115 // TODO(guidou): The label argument should have [TreatNullAs=EmptyString] 115 // TODO(guidou): The label argument should have [TreatNullAs=EmptyString]
116 // and be non-nullable. 116 // and be non-nullable.
117 [RaisesException] RTCDataChannel createDataChannel([TreatUndefinedAs=NullStr ing] DOMString? label, optional Dictionary options); 117 [RaisesException] RTCDataChannel createDataChannel([TreatUndefinedAs=NullStr ing] DOMString? label, optional Dictionary options);
118 attribute EventHandler ondatachannel; 118 attribute EventHandler ondatachannel;
119 119
120 // Non-standard or removed from the spec: 120 // Non-standard or removed from the spec:
121 [CallWith=ExecutionContext, RaisesException] void updateIce(optional Diction ary configuration, optional Dictionary mediaConstraints); 121 [CallWith=ExecutionContext, RaisesException] void updateIce(optional Diction ary configuration, optional Dictionary mediaConstraints);
122 sequence<MediaStream> getLocalStreams(); 122 sequence<MediaStream> getLocalStreams();
123 sequence<MediaStream> getRemoteStreams(); 123 sequence<MediaStream> getRemoteStreams();
124 MediaStream getStreamById(DOMString streamId); 124 MediaStream getStreamById(DOMString streamId);
125 [CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? str eam, optional Dictionary mediaConstraints); 125 [CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? str eam, optional Dictionary mediaConstraints);
126 [RaisesException] void removeStream(MediaStream? stream); 126 [RaisesException] void removeStream(MediaStream? stream);
127 [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track); 127 [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
128 attribute EventHandler onaddstream; 128 attribute EventHandler onaddstream;
129 attribute EventHandler onremovestream; 129 attribute EventHandler onremovestream;
130 130
131 // Certificate management 131 // Certificate management
132 // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt 132 // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt
133 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm); 133 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm);
134 }; 134 };
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698