Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2198003002: GN: Set |enable_webvr| in the declare_args() block. (Closed)

Created:
4 years, 4 months ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, brettw, bajones
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Set |enable_webvr| in the declare_args() block. This effectively makes it a configurable argument that can be changed by downstreams and users alike; so far, trying to change it via `gn args' failed with: The variable "enable_webvr" was set as a build argument but never appeared in a declare_args() block in any buildfile. BUG=389343 R=bajones@chromium.org,brettw@chromium.org,dpranke@chromium.org Committed: https://crrev.com/c699e89f096292539b287b7917441ed19d13a2e9 Cr-Commit-Position: refs/heads/master@{#409083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/config/features.gni View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Raphael Kubo da Costa (rakuco)
PTAL. > This effectively makes it a configurable argument that can be changed by downstreams ...
4 years, 4 months ago (2016-08-01 12:44:27 UTC) #1
brettw
lgtm
4 years, 4 months ago (2016-08-01 18:20:47 UTC) #2
bajones
LGTM
4 years, 4 months ago (2016-08-01 18:22:41 UTC) #3
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-01 18:28:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198003002/1
4 years, 4 months ago (2016-08-01 21:39:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 22:51:59 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 23:03:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c699e89f096292539b287b7917441ed19d13a2e9
Cr-Commit-Position: refs/heads/master@{#409083}

Powered by Google App Engine
This is Rietveld 408576698