Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Side by Side Diff: build/config/features.gni

Issue 2198003002: GN: Set |enable_webvr| in the declare_args() block. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains Chrome-feature-related build flags (see ui.gni for 5 # This file contains Chrome-feature-related build flags (see ui.gni for
6 # UI-related ones). These should theoretically be moved to the build files of 6 # UI-related ones). These should theoretically be moved to the build files of
7 # the features themselves. 7 # the features themselves.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 111
112 # Enable basic printing support and UI. 112 # Enable basic printing support and UI.
113 enable_basic_printing = !is_chromecast && !is_ios 113 enable_basic_printing = !is_chromecast && !is_ios
114 114
115 # Enable printing with print preview. It does not imply 115 # Enable printing with print preview. It does not imply
116 # enable_basic_printing. It's possible to build Chrome with preview only. 116 # enable_basic_printing. It's possible to build Chrome with preview only.
117 enable_print_preview = !is_android && !is_chromecast && !is_ios 117 enable_print_preview = !is_android && !is_chromecast && !is_ios
118 118
119 # Whether or not to use external popup menu. 119 # Whether or not to use external popup menu.
120 use_external_popup_menu = is_android || is_mac 120 use_external_popup_menu = is_android || is_mac
121
122 # Enable WebVR support by default on Android
123 # Still requires command line flag to access API
124 enable_webvr = is_android
121 } 125 }
122 126
123 # Additional dependent variables ----------------------------------------------- 127 # Additional dependent variables -----------------------------------------------
124 128
125 # Enable the spell checker. 129 # Enable the spell checker.
126 enable_spellcheck = !is_ios 130 enable_spellcheck = !is_ios
127 131
128 # Use the operating system's spellchecker rather than hunspell. 132 # Use the operating system's spellchecker rather than hunspell.
129 use_browser_spellchecker = is_android || is_mac 133 use_browser_spellchecker = is_android || is_mac
130 134
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 # Image loader extension is enabled on ChromeOS only. 167 # Image loader extension is enabled on ChromeOS only.
164 enable_image_loader_extension = is_chromeos 168 enable_image_loader_extension = is_chromeos
165 169
166 # Chrome OS: whether to also build the upcoming version of 170 # Chrome OS: whether to also build the upcoming version of
167 # ChromeVox, which can then be enabled via a command-line switch. 171 # ChromeVox, which can then be enabled via a command-line switch.
168 enable_chromevox_next = false 172 enable_chromevox_next = false
169 173
170 # Use brlapi from brltty for braille display support. 174 # Use brlapi from brltty for braille display support.
171 use_brlapi = is_chromeos 175 use_brlapi = is_chromeos
172 176
173 # Enable WebVR support by default on Android
174 # Still requires command line flag to access API
175 enable_webvr = is_android
176
177 enable_configuration_policy = !is_ios 177 enable_configuration_policy = !is_ios
178 178
179 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 179 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
180 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build 180 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698