Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2197943002: MD Settings: fix a couple errors (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix a couple errors Fix an error when navigating Chrome to a section (e.g. chrome://md-settings/search). Remove an observer that was removed. BUG=631332 R=dschyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0608e39162e98e0e1d5e80bcb043899f4d513953 Cr-Commit-Position: refs/heads/master@{#409024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
michaelpg
ptal.
4 years, 4 months ago (2016-08-01 07:57:30 UTC) #2
michaelpg
resending to the real dschuyler
4 years, 4 months ago (2016-08-01 15:30:05 UTC) #4
dschuyler
lgtm
4 years, 4 months ago (2016-08-01 18:29:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197943002/1
4 years, 4 months ago (2016-08-01 18:32:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 19:29:48 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 19:32:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0608e39162e98e0e1d5e80bcb043899f4d513953
Cr-Commit-Position: refs/heads/master@{#409024}

Powered by Google App Engine
This is Rietveld 408576698