Revert of Fold compositing display items into contained drawings if the drawing is a singleton.

Revert of Fold compositing display items into contained drawings if the drawing is a singleton. (patchset #7 id:110001 of https://codereview.chromium.org/2186643002/ )

Reason for revert:
This CL seems to break layout tests on bot.
An example of failure is:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/results/layout-test-results/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-crash-log.txt

STDERR: [4:4:0731/203155:3802475433:FATAL:PaintController.cpp(554)] Check failed: false.
STDERR: #0 0x7f109c38b99e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f109c3f2fef logging::LogMessage::~LogMessage()
STDERR: #2 0x7f1097594655 blink::PaintController::checkUnderInvalidation()
STDERR: #3 0x7f1097592e64 blink::PaintController::processNewItem()
STDERR: #4 0x7f1097583d52 _ZN5blink15PaintController15createAndAppendINS_18DrawingDisplayItemEJRKNS_17DisplayItemClientERKNS_11DisplayItem4TypeEN3WTF10PassRefPtrI9SkPictureEERbEEEvDpOT0_
STDERR: #5 0x7f1097583af1 blink::DrawingRecorder::~DrawingRecorder()
STDERR: #6 0x7f109422f925 base::internal::OptionalStorage<>::~OptionalStorage()
STDERR: #7 0x7f109422f8c5 base::Optional<>::~Optional()
STDERR: #8 0x7f109422ed83 blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder()
STDERR: #9 0x7f109423e187 blink::BoxPainter::paintBoxDecorationBackgroundWithRect()
STDERR: #10 0x7f109423dcde blink::BoxPainter::paintBoxDecorationBackground()
STDERR: #11 0x7f10943f34f5 blink::LayoutBox::paintBoxDecorationBackground()
STDERR: #12 0x7f109422dbcd blink::BlockPainter::paintObject()
STDERR: #13 0x7f10943b1bd5 blink::LayoutBlock::paintObject()
STDERR: #14 0x7f109422d25c blink::BlockPainter::paint()
STDERR: #15 0x7f10943b1b55 blink::LayoutBlock::paint()

Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a singleton.
>
> BUG=628831
>
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}

TBR=fmalita@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org,chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628831
Committed: https://crrev.com/46344c2a474c1599c6cbc44297a1b9afcae04bb6
Cr-Commit-Position: refs/heads/master@{#408928}

[tzik, 2016-08-01 04:52:12]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-08-01 04:52:13]

Created Revert of Fold compositing display items into contained drawings if the
drawing is a singleton.

[commit-bot: I haz the power, 2016-08-01 04:52:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 08:03:35]

Description was changed from

==========
Revert of Fold compositing display items into contained drawings if the drawing
is a singleton. (patchset #7 id:110001 of
https://codereview.chromium.org/2186643002/ )

Reason for revert:
This CL seems to break layout tests on bot.
An example of failure is:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...

STDERR: [4:4:0731/203155:3802475433:FATAL:PaintController.cpp(554)] Check
failed: false. 
STDERR: #0 0x7f109c38b99e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f109c3f2fef logging::LogMessage::~LogMessage()
STDERR: #2 0x7f1097594655 blink::PaintController::checkUnderInvalidation()
STDERR: #3 0x7f1097592e64 blink::PaintController::processNewItem()
STDERR: #4 0x7f1097583d52
_ZN5blink15PaintController15createAndAppendINS_18DrawingDisplayItemEJRKNS_17DisplayItemClientERKNS_11DisplayItem4TypeEN3WTF10PassRefPtrI9SkPictureEERbEEEvDpOT0_
STDERR: #5 0x7f1097583af1 blink::DrawingRecorder::~DrawingRecorder()
STDERR: #6 0x7f109422f925 base::internal::OptionalStorage<>::~OptionalStorage()
STDERR: #7 0x7f109422f8c5 base::Optional<>::~Optional()
STDERR: #8 0x7f109422ed83
blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder()
STDERR: #9 0x7f109423e187
blink::BoxPainter::paintBoxDecorationBackgroundWithRect()
STDERR: #10 0x7f109423dcde blink::BoxPainter::paintBoxDecorationBackground()
STDERR: #11 0x7f10943f34f5 blink::LayoutBox::paintBoxDecorationBackground()
STDERR: #12 0x7f109422dbcd blink::BlockPainter::paintObject()
STDERR: #13 0x7f10943b1bd5 blink::LayoutBlock::paintObject()
STDERR: #14 0x7f109422d25c blink::BlockPainter::paint()
STDERR: #15 0x7f10943b1b55 blink::LayoutBlock::paint()

Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a
singleton.
> 
> BUG=628831
> 
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}

TBR=fmalita@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org,chrish...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628831
==========

to

==========
Revert of Fold compositing display items into contained drawings if the drawing
is a singleton. (patchset #7 id:110001 of
https://codereview.chromium.org/2186643002/ )

Reason for revert:
This CL seems to break layout tests on bot.
An example of failure is:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...

STDERR: [4:4:0731/203155:3802475433:FATAL:PaintController.cpp(554)] Check
failed: false. 
STDERR: #0 0x7f109c38b99e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f109c3f2fef logging::LogMessage::~LogMessage()
STDERR: #2 0x7f1097594655 blink::PaintController::checkUnderInvalidation()
STDERR: #3 0x7f1097592e64 blink::PaintController::processNewItem()
STDERR: #4 0x7f1097583d52
_ZN5blink15PaintController15createAndAppendINS_18DrawingDisplayItemEJRKNS_17DisplayItemClientERKNS_11DisplayItem4TypeEN3WTF10PassRefPtrI9SkPictureEERbEEEvDpOT0_
STDERR: #5 0x7f1097583af1 blink::DrawingRecorder::~DrawingRecorder()
STDERR: #6 0x7f109422f925 base::internal::OptionalStorage<>::~OptionalStorage()
STDERR: #7 0x7f109422f8c5 base::Optional<>::~Optional()
STDERR: #8 0x7f109422ed83
blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder()
STDERR: #9 0x7f109423e187
blink::BoxPainter::paintBoxDecorationBackgroundWithRect()
STDERR: #10 0x7f109423dcde blink::BoxPainter::paintBoxDecorationBackground()
STDERR: #11 0x7f10943f34f5 blink::LayoutBox::paintBoxDecorationBackground()
STDERR: #12 0x7f109422dbcd blink::BlockPainter::paintObject()
STDERR: #13 0x7f10943b1bd5 blink::LayoutBlock::paintObject()
STDERR: #14 0x7f109422d25c blink::BlockPainter::paint()
STDERR: #15 0x7f10943b1b55 blink::LayoutBlock::paint()

Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a
singleton.
> 
> BUG=628831
> 
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}

TBR=fmalita@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org,chrish...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628831
==========

[commit-bot: I haz the power, 2016-08-01 08:03:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-01 08:06:17]

Description was changed from

==========
Revert of Fold compositing display items into contained drawings if the drawing
is a singleton. (patchset #7 id:110001 of
https://codereview.chromium.org/2186643002/ )

Reason for revert:
This CL seems to break layout tests on bot.
An example of failure is:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...

STDERR: [4:4:0731/203155:3802475433:FATAL:PaintController.cpp(554)] Check
failed: false. 
STDERR: #0 0x7f109c38b99e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f109c3f2fef logging::LogMessage::~LogMessage()
STDERR: #2 0x7f1097594655 blink::PaintController::checkUnderInvalidation()
STDERR: #3 0x7f1097592e64 blink::PaintController::processNewItem()
STDERR: #4 0x7f1097583d52
_ZN5blink15PaintController15createAndAppendINS_18DrawingDisplayItemEJRKNS_17DisplayItemClientERKNS_11DisplayItem4TypeEN3WTF10PassRefPtrI9SkPictureEERbEEEvDpOT0_
STDERR: #5 0x7f1097583af1 blink::DrawingRecorder::~DrawingRecorder()
STDERR: #6 0x7f109422f925 base::internal::OptionalStorage<>::~OptionalStorage()
STDERR: #7 0x7f109422f8c5 base::Optional<>::~Optional()
STDERR: #8 0x7f109422ed83
blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder()
STDERR: #9 0x7f109423e187
blink::BoxPainter::paintBoxDecorationBackgroundWithRect()
STDERR: #10 0x7f109423dcde blink::BoxPainter::paintBoxDecorationBackground()
STDERR: #11 0x7f10943f34f5 blink::LayoutBox::paintBoxDecorationBackground()
STDERR: #12 0x7f109422dbcd blink::BlockPainter::paintObject()
STDERR: #13 0x7f10943b1bd5 blink::LayoutBlock::paintObject()
STDERR: #14 0x7f109422d25c blink::BlockPainter::paint()
STDERR: #15 0x7f10943b1b55 blink::LayoutBlock::paint()

Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a
singleton.
> 
> BUG=628831
> 
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}

TBR=fmalita@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org,chrish...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628831
==========

to

==========
Revert of Fold compositing display items into contained drawings if the drawing
is a singleton. (patchset #7 id:110001 of
https://codereview.chromium.org/2186643002/ )

Reason for revert:
This CL seems to break layout tests on bot.
An example of failure is:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...

STDERR: [4:4:0731/203155:3802475433:FATAL:PaintController.cpp(554)] Check
failed: false.
STDERR: #0 0x7f109c38b99e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f109c3f2fef logging::LogMessage::~LogMessage()
STDERR: #2 0x7f1097594655 blink::PaintController::checkUnderInvalidation()
STDERR: #3 0x7f1097592e64 blink::PaintController::processNewItem()
STDERR: #4 0x7f1097583d52
_ZN5blink15PaintController15createAndAppendINS_18DrawingDisplayItemEJRKNS_17DisplayItemClientERKNS_11DisplayItem4TypeEN3WTF10PassRefPtrI9SkPictureEERbEEEvDpOT0_
STDERR: #5 0x7f1097583af1 blink::DrawingRecorder::~DrawingRecorder()
STDERR: #6 0x7f109422f925 base::internal::OptionalStorage<>::~OptionalStorage()
STDERR: #7 0x7f109422f8c5 base::Optional<>::~Optional()
STDERR: #8 0x7f109422ed83
blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder()
STDERR: #9 0x7f109423e187
blink::BoxPainter::paintBoxDecorationBackgroundWithRect()
STDERR: #10 0x7f109423dcde blink::BoxPainter::paintBoxDecorationBackground()
STDERR: #11 0x7f10943f34f5 blink::LayoutBox::paintBoxDecorationBackground()
STDERR: #12 0x7f109422dbcd blink::BlockPainter::paintObject()
STDERR: #13 0x7f10943b1bd5 blink::LayoutBlock::paintObject()
STDERR: #14 0x7f109422d25c blink::BlockPainter::paint()
STDERR: #15 0x7f10943b1b55 blink::LayoutBlock::paint()

Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a
singleton.
>
> BUG=628831
>
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}

TBR=fmalita@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org,chrish...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628831

Committed: https://crrev.com/46344c2a474c1599c6cbc44297a1b9afcae04bb6
Cr-Commit-Position: refs/heads/master@{#408928}
==========

[commit-bot: I haz the power, 2016-08-01 08:06:19]

Patchset 1 (id:??) landed as
https://crrev.com/46344c2a474c1599c6cbc44297a1b9afcae04bb6
Cr-Commit-Position: refs/heads/master@{#408928}

[Xianzhu, 2016-08-01 15:33:15]

Chris, this is probably caused by my under-invalidation code. I'll investigate
and fix the issue.