Move LoaderIOThreadNotifier out of resource_dispatcher_host_impl.h

Move LoaderIOThreadNotifier out of resource_dispatcher_host_impl.h

Lets decouple the two classes so that we can expand LoaderIOThreadNotifier
for Size Policy

BUG=629587
Committed: https://crrev.com/2e8c98e4265e393849d7cb6190035d007f7b779a
Cr-Commit-Position: refs/heads/master@{#409092}

[Charlie Harrison, 2016-07-29 19:27:37]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 19:28:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-07-29 20:14:20]

csharrison@chromium.org changed reviewers:
+ mmenke@chromium.org

[Charlie Harrison, 2016-07-29 20:14:20]

PTAL at this trivial CL. This should hopefully make the Size Policy changes a
bit more contained.

[Charlie Harrison, 2016-07-29 20:15:17]

csharrison@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Harrison, 2016-07-29 20:15:17]

+nasko could you please review the change to web_contents_impl.cc?

[mmenke, 2016-07-29 20:30:12]

LGTM

https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_impl.cc:1816: void
ResourceDispatcherHostImpl::OnRenderFrameDeleted(
Should try and match declaration order with definition order (Though this file
does look rather badly out of order...)

[Charlie Harrison, 2016-07-29 20:35:29]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[Charlie Harrison, 2016-07-29 20:35:34]

Thanks.

https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_impl.cc:1816: void
ResourceDispatcherHostImpl::OnRenderFrameDeleted(
On 2016/07/29 20:30:12, mmenke wrote:
> Should try and match declaration order with definition order (Though this file
> does look rather badly out of order...)

Moved it after SetLoaderDelegate. I wonder if we could have a tool that matches
declaration/definition order?

[commit-bot: I haz the power, 2016-07-29 20:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-07-29 20:36:27]

On 2016/07/29 20:35:34, csharrison wrote:
> Thanks.
> 
>
https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
> File content/browser/loader/resource_dispatcher_host_impl.cc (right):
> 
>
https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
> content/browser/loader/resource_dispatcher_host_impl.cc:1816: void
> ResourceDispatcherHostImpl::OnRenderFrameDeleted(
> On 2016/07/29 20:30:12, mmenke wrote:
> > Should try and match declaration order with definition order (Though this
file
> > does look rather badly out of order...)
> 
> Moved it after SetLoaderDelegate. I wonder if we could have a tool that
matches
> declaration/definition order?

We have many such tools.  They're known as interns.  :)

[mmenke, 2016-07-29 20:37:13]

On 2016/07/29 20:36:27, mmenke wrote:
> On 2016/07/29 20:35:34, csharrison wrote:
> > Thanks.
> > 
> >
>
https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
> > File content/browser/loader/resource_dispatcher_host_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/2197763002/diff/1/content/browser/loader/reso...
> > content/browser/loader/resource_dispatcher_host_impl.cc:1816: void
> > ResourceDispatcherHostImpl::OnRenderFrameDeleted(
> > On 2016/07/29 20:30:12, mmenke wrote:
> > > Should try and match declaration order with definition order (Though this
> file
> > > does look rather badly out of order...)
> > 
> > Moved it after SetLoaderDelegate. I wonder if we could have a tool that
> matches
> > declaration/definition order?
> 
> We have many such tools.  They're known as interns.  :)

(Actually, I think I'll fix the order myself, once the pending reviews I have in
that area are done and the CLs are landed)

[commit-bot: I haz the power, 2016-07-29 21:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:18:36]

Dry run: This issue passed the CQ dry run.

[nasko, 2016-08-01 22:44:40]

Just an include?! LGTM

[Charlie Harrison, 2016-08-01 22:48:38]

Hah, thanks :)

[Charlie Harrison, 2016-08-01 22:48:44]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-08-01 22:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2197763002/#ps20001
(title: "move definition")

[commit-bot: I haz the power, 2016-08-01 22:49:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 23:56:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 00:02:35]

Description was changed from

==========
Move LoaderIOThreadNotifier out of resource_dispatcher_host_impl.h

Lets decouple the two classes so that we can expand LoaderIOThreadNotifier
for Size Policy

BUG=629587
==========

to

==========
Move LoaderIOThreadNotifier out of resource_dispatcher_host_impl.h

Lets decouple the two classes so that we can expand LoaderIOThreadNotifier
for Size Policy

BUG=629587

Committed: https://crrev.com/2e8c98e4265e393849d7cb6190035d007f7b779a
Cr-Commit-Position: refs/heads/master@{#409092}
==========

[commit-bot: I haz the power, 2016-08-02 00:02:36]

Patchset 2 (id:??) landed as
https://crrev.com/2e8c98e4265e393849d7cb6190035d007f7b779a
Cr-Commit-Position: refs/heads/master@{#409092}

[mmenke, 2016-08-02 14:43:39]

On 2016/08/01 22:48:38, csharrison wrote:
> Hah, thanks :)

You can just TBR changes that minor.  Don't want to be too aggressive on TBRs,
but think that change meets the bar.