Move LoaderIOThreadNotifier out of resource_dispatcher_host_impl.h

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <stddef.h>
 
@@ skipping 475 matching lines @@
     if (pending_frame_host)
       routing_ids->insert(pending_frame_host->GetGlobalFrameRoutingId());
   }
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                           base::Bind(&NotifyForRouteSetOnIO, frame_callback,
                                      base::Passed(std::move(routing_ids))));
 }
 
 }  // namespace
 
-LoaderIOThreadNotifier::LoaderIOThreadNotifier(WebContents* web_contents)
-    : WebContentsObserver(web_contents) {}
-
-LoaderIOThreadNotifier::~LoaderIOThreadNotifier() {}
-
-void LoaderIOThreadNotifier::RenderFrameDeleted(
-    RenderFrameHost* render_frame_host) {
-  NotifyForRouteFromUI(
-      static_cast<RenderFrameHostImpl*>(render_frame_host)
-          ->GetGlobalFrameRoutingId(),
-      base::Bind(&ResourceDispatcherHostImpl::OnRenderFrameDeleted));
-}
-
 // static
 ResourceDispatcherHost* ResourceDispatcherHost::Get() {
   return g_resource_dispatcher_host;
 }
 
 ResourceDispatcherHostImpl::ResourceDispatcherHostImpl()
     : save_file_manager_(new SaveFileManager()),
       request_id_(-1),
       is_shutdown_(false),
       num_in_flight_requests_(0),
@@ skipping 1300 matching lines @@
       context,
       base::WeakPtr<ResourceMessageFilter>(),  // filter
       false,                                   // report_raw_headers
       true,                                    // is_async
       false,                                   // is_using_lofi
       std::string(),                           // original_headers
       nullptr,                                 // body
       false);                                  // initiated_in_secure_context
 }
 
 void ResourceDispatcherHostImpl::OnRenderFrameDeleted(

[mmenke, 2016/07/29 20:30:12]

Should try and match declaration order with definition order (Though this file
does look rather badly out of order...)

[Charlie Harrison, 2016/07/29 20:35:34]

Moved it after SetLoaderDelegate. I wonder if we could have a tool that matches
declaration/definition order?

     const GlobalFrameRoutingId& global_routing_id) {
   CancelRequestsForRoute(global_routing_id);
 }
 
 void ResourceDispatcherHostImpl::OnRenderViewHostCreated(int child_id,
                                                          int route_id) {
   scheduler_->OnClientCreated(child_id, route_id);
 }
 
 void ResourceDispatcherHostImpl::OnRenderViewHostDeleted(int child_id,
@@ skipping 774 matching lines @@
   ssl.cert_id = GetCertStore()->StoreCert(ssl_info.cert.get(), child_id);
   response->head.security_info = SerializeSecurityInfo(ssl);
 }
 
 CertStore* ResourceDispatcherHostImpl::GetCertStore() {
   return cert_store_for_testing_ ? cert_store_for_testing_
                                  : CertStore::GetInstance();
 }
 
 }  // namespace content