Comment out an identifier for for an obsolete infobar, and notate

components/infobars/core/infobar_delegate.h

Index: components/infobars/core/infobar_delegate.h
diff --git a/components/infobars/core/infobar_delegate.h b/components/infobars/core/infobar_delegate.h
index 16d546f926f00a2940be7d3bfed9792bb96ef50f..07d7ce7b8eb9b11642b0585e10eb570dc7c02433 100644
--- a/components/infobars/core/infobar_delegate.h
+++ b/components/infobars/core/infobar_delegate.h
@@ -85,7 +85,7 @@ class InfoBarDelegate {
     THEME_INSTALLED_INFOBAR_DELEGATE = 15,
     GEOLOCATION_INFOBAR_DELEGATE_ANDROID = 16,
     THREE_D_API_INFOBAR_DELEGATE = 17,
-    INSECURE_CONTENT_INFOBAR_DELEGATE = 18,
+    // Removed: INSECURE_CONTENT_INFOBAR_DELEGATE = 18,
     MIDI_PERMISSION_INFOBAR_DELEGATE_ANDROID = 19,
     PROTECTED_MEDIA_IDENTIFIER_INFOBAR_DELEGATE_ANDROID = 20,
     NACL_INFOBAR_DELEGATE = 21,
@@ -124,9 +124,9 @@ class InfoBarDelegate {
     NATIVE_APP_OPEN_POLICY_INFOBAR_DELEGATE = 54,
     RE_SIGN_IN_INFOBAR_DELEGATE = 55,
     SHOW_PASSKIT_INFOBAR_ERROR_DELEGATE = 56,
-    READER_MODE_INFOBAR_DELEGATE = 57,
+    READER_MODE_INFOBAR_DELEGATE = 57,  // Used on iOS.
     SYNC_ERROR_INFOBAR_DELEGATE = 58,
-    UPGRADE_INFOBAR_DELEGATE = 59,
+    UPGRADE_INFOBAR_DELEGATE = 59,  // Used on iOS.

[Evan Stade, 2016/07/29 17:10:39]

I would have preferred to change the names to ..._IOS but that would break iOS
and then someone would revert this patch.

[Peter Kasting, 2016/07/29 19:10:05]

I thought iOS was fully upstreamed?  They still have private code using these?

Can we just ask dfalcantara to make the naming change here or else comment these
out if they're dead?

[gone, 2016/07/29 20:00:57]

I don't do iOS development and don't know who to ask nowadays :/

[gone, 2016/07/29 20:01:35]

(Mainly because I don't know if I even have access to the source.)

[jif-google, 2016/08/01 12:08:06]

Chrome for iOS eng here.
I realize that it's super annoying for a random engineer to revert a CL just
because their downstream  usage gets broken. I sincerely apologize for that.
Chrome for iOS used to be a fork of Chrome. This has recently stopped being the
case; maybe this is what you were thinking of?

Unfortunately, Chrome iOS is still mostly in a private repo (whose code is
mirrored in Google3 btw) in which we "roll" chromium code.

We have several people working fulltime on upstreaming all the iOS code.
rohitrao@ or sdefresne@ can talk to you about the various challenges we are
facing (this includes rewriting the integration tests and stop using some iOS
libraries shared across Google Apps).
Again, sorry about that.
I tried to not revert the patch by defining the removed constants downstream,
but it was deemed "too ugly".
Renaming the names to ..._IOS is not a problem. It would indeed break iOS, but
it would be an easy fix for us. I'm writing a CL now.

     CHROME_WINDOW_ERROR = 60,
     CONFIRM_DANGEROUS_DOWNLOAD = 61,
     // Removed: DESKTOP_SEARCH_REDIRECTION_INFOBAR_DELEGATE = 62,