Comment out an identifier for for an obsolete infobar, and notate

components/infobars/core/infobar_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_INFOBARS_CORE_INFOBAR_DELEGATE_H_
 #define COMPONENTS_INFOBARS_CORE_INFOBAR_DELEGATE_H_
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
@@ skipping 67 matching lines @@
     HUNG_RENDERER_INFOBAR_DELEGATE = 8,
     MEDIA_STREAM_INFOBAR_DELEGATE_ANDROID = 9,
     MEDIA_THROTTLE_INFOBAR_DELEGATE = 10,
     REQUEST_QUOTA_INFOBAR_DELEGATE = 11,
     DEV_TOOLS_CONFIRM_INFOBAR_DELEGATE = 12,
     EXTENSION_DEV_TOOLS_INFOBAR_DELEGATE = 13,
     INCOGNITO_CONNECTABILITY_INFOBAR_DELEGATE = 14,
     THEME_INSTALLED_INFOBAR_DELEGATE = 15,
     GEOLOCATION_INFOBAR_DELEGATE_ANDROID = 16,
     THREE_D_API_INFOBAR_DELEGATE = 17,
-    INSECURE_CONTENT_INFOBAR_DELEGATE = 18,
+    // Removed: INSECURE_CONTENT_INFOBAR_DELEGATE = 18,
     MIDI_PERMISSION_INFOBAR_DELEGATE_ANDROID = 19,
     PROTECTED_MEDIA_IDENTIFIER_INFOBAR_DELEGATE_ANDROID = 20,
     NACL_INFOBAR_DELEGATE = 21,
     // Removed: DATA_REDUCTION_PROXY_INFOBAR_DELEGATE_ANDROID = 22,
     NOTIFICATION_PERMISSION_INFOBAR_DELEGATE = 23,
     AUTO_SIGNIN_FIRST_RUN_INFOBAR_DELEGATE = 24,
     GENERATED_PASSWORD_SAVED_INFOBAR_DELEGATE_ANDROID = 25,
     SAVE_PASSWORD_INFOBAR_DELEGATE = 26,
     PEPPER_BROKER_INFOBAR_DELEGATE = 27,
     PERMISSION_UPDATE_INFOBAR_DELEGATE = 28,
@@ skipping 18 matching lines @@
     SESSION_CRASHED_INFOBAR_DELEGATE = 47,
     WEBSITE_SETTINGS_INFOBAR_DELEGATE = 48,
     AUTOFILL_CC_INFOBAR_DELEGATE = 49,
     TRANSLATE_INFOBAR_DELEGATE = 50,
     IOS_CHROME_SAVE_PASSWORD_INFOBAR_DELEGATE = 51,
     NATIVE_APP_INSTALLER_INFOBAR_DELEGATE = 52,
     NATIVE_APP_LAUNCHER_INFOBAR_DELEGATE = 53,
     NATIVE_APP_OPEN_POLICY_INFOBAR_DELEGATE = 54,
     RE_SIGN_IN_INFOBAR_DELEGATE = 55,
     SHOW_PASSKIT_INFOBAR_ERROR_DELEGATE = 56,
-    READER_MODE_INFOBAR_DELEGATE = 57,
+    READER_MODE_INFOBAR_DELEGATE = 57,  // Used on iOS.
     SYNC_ERROR_INFOBAR_DELEGATE = 58,
-    UPGRADE_INFOBAR_DELEGATE = 59,
+    UPGRADE_INFOBAR_DELEGATE = 59,  // Used on iOS.

[Evan Stade, 2016/07/29 17:10:39]

I would have preferred to change the names to ..._IOS but that would break iOS
and then someone would revert this patch.

[Peter Kasting, 2016/07/29 19:10:05]

I thought iOS was fully upstreamed?  They still have private code using these?

Can we just ask dfalcantara to make the naming change here or else comment these
out if they're dead?

[gone, 2016/07/29 20:00:57]

I don't do iOS development and don't know who to ask nowadays :/

[gone, 2016/07/29 20:01:35]

(Mainly because I don't know if I even have access to the source.)

[jif-google, 2016/08/01 12:08:06]

Chrome for iOS eng here.
I realize that it's super annoying for a random engineer to revert a CL just
because their downstream  usage gets broken. I sincerely apologize for that.
Chrome for iOS used to be a fork of Chrome. This has recently stopped being the
case; maybe this is what you were thinking of?

Unfortunately, Chrome iOS is still mostly in a private repo (whose code is
mirrored in Google3 btw) in which we "roll" chromium code.

We have several people working fulltime on upstreaming all the iOS code.
rohitrao@ or sdefresne@ can talk to you about the various challenges we are
facing (this includes rewriting the integration tests and stop using some iOS
libraries shared across Google Apps).
Again, sorry about that.
I tried to not revert the patch by defining the removed constants downstream,
but it was deemed "too ugly".
Renaming the names to ..._IOS is not a problem. It would indeed break iOS, but
it would be an easy fix for us. I'm writing a CL now.

     CHROME_WINDOW_ERROR = 60,
     CONFIRM_DANGEROUS_DOWNLOAD = 61,
     // Removed: DESKTOP_SEARCH_REDIRECTION_INFOBAR_DELEGATE = 62,
     UPDATE_PASSWORD_INFOBAR_DELEGATE = 63,
     DATA_REDUCTION_PROMO_INFOBAR_DELEGATE_ANDROID = 64,
   };
 
   // Describes navigation events, used to decide whether infobars should be
   // dismissed.
   struct NavigationDetails {
@@ skipping 92 matching lines @@
 
   // The ID of the active navigation entry at the time we became owned.
   int nav_entry_id_;
 
   DISALLOW_COPY_AND_ASSIGN(InfoBarDelegate);
 };
 
 }  // namespace infobars
 
 #endif  // COMPONENTS_INFOBARS_CORE_INFOBAR_DELEGATE_H_