Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2197653004: DevTools: do not apply number editings shortcuts to HTML attributes which look like URL (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not apply number editings shortcuts to HTML attributes which look like URL BUG=596181 R=dgozman Committed: https://crrev.com/9d3e6d4a5d416197864ddc2a329b84ce5124667d Cr-Commit-Position: refs/heads/master@{#408853}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sweet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
lushnikov
please, take a look
4 years, 4 months ago (2016-07-29 22:02:34 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2197653004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js (right): https://codereview.chromium.org/2197653004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js#newcode682 third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js:682: if (!(new WebInspector.ParsedURL(attributeValueElement.textContent).isValid)) if (!attributeValueElement.textContent.asParsedURL())
4 years, 4 months ago (2016-07-29 23:12:38 UTC) #4
lushnikov
https://codereview.chromium.org/2197653004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js (right): https://codereview.chromium.org/2197653004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js#newcode682 third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js:682: if (!(new WebInspector.ParsedURL(attributeValueElement.textContent).isValid)) On 2016/07/29 23:12:38, dgozman wrote: > ...
4 years, 4 months ago (2016-07-29 23:29:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197653004/20001
4 years, 4 months ago (2016-07-29 23:30:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-30 03:07:14 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 03:08:28 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9d3e6d4a5d416197864ddc2a329b84ce5124667d
Cr-Commit-Position: refs/heads/master@{#408853}

Powered by Google App Engine
This is Rietveld 408576698