third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2197653004: DevTools: do not apply number editings shortcuts to HTML attributes which look like URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2197653004: DevTools: do not apply number editings shortcuts to HTML attributes which look like URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sweet Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index f00de1e730c3a007edf88f74aad57414255d5341..3d040a31fadd0c9cd3d9c8e2dec428f33499aafc 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -678,7 +678,9 @@ WebInspector.ElementsTreeElement.prototype = {

WebInspector.handleElementValueModifications(event, attribute);

return "";

}

- config.setPostKeydownFinishHandler(postKeyDownFinishHandler);

+ if (!attributeValueElement.textContent.asParsedURL())

+ config.setPostKeydownFinishHandler(postKeyDownFinishHandler);

this._editing = WebInspector.InplaceEditor.startEditing(attribute, config);

« no previous file with comments | « no previous file | no next file » | no next file with comments »