Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Issue 2197633002: GN: components as static library instead of source set (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: components as static library instead of source set This also puts the .a in the top-level of the ouptut directory, just like we do for .so files. It's less required than for .sos, but it does make it easier to find the .a. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197633002 Committed: https://skia.googlesource.com/skia/+/5db44aa2aa4a3a1b9ce1fe7e22c54c8d9b61f51d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gn/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gn/BUILDCONFIG.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
4 years, 4 months ago (2016-07-29 15:05:24 UTC) #3
stephana
On 2016/07/29 15:05:24, mtklein_C wrote: lgtm but my GN knowledge is still very limited
4 years, 4 months ago (2016-07-29 15:10:40 UTC) #4
mtklein
On 2016/07/29 15:10:40, stephana wrote: > On 2016/07/29 15:05:24, mtklein_C wrote: > > lgtm but ...
4 years, 4 months ago (2016-07-29 15:11:15 UTC) #5
jcgregorio
lgtm
4 years, 4 months ago (2016-07-29 15:11:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197633002/1
4 years, 4 months ago (2016-07-29 15:11:41 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 16:10:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5db44aa2aa4a3a1b9ce1fe7e22c54c8d9b61f51d

Powered by Google App Engine
This is Rietveld 408576698