Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: gn/BUILDCONFIG.gn

Issue 2197633002: GN: components as static library instead of source set (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gn/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gn/BUILDCONFIG.gn
diff --git a/gn/BUILDCONFIG.gn b/gn/BUILDCONFIG.gn
index 31056bda5f1b9ad11ef66d7a3a8d5a4a8cf425df..681b15b83bad2ce2a2a783c45a3ae79a7cee0765 100644
--- a/gn/BUILDCONFIG.gn
+++ b/gn/BUILDCONFIG.gn
@@ -27,9 +27,9 @@ is_win = current_os == "win"
is_posix = !is_win
-# A component is either a source_set or a shared_library.
+# A component is either a static or a shared library.
template("component") {
- _component_mode = "source_set"
+ _component_mode = "static_library"
if (is_component_build) {
_component_mode = "shared_library"
}
« no previous file with comments | « gn/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698