Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.h

Issue 2197573003: Provide API in RequestCoordinator to remove results by client ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per DougArnett Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_in_memory_store.h
diff --git a/components/offline_pages/background/request_queue_in_memory_store.h b/components/offline_pages/background/request_queue_in_memory_store.h
index 0a9b8bdb323337a9ddcfce877689717d01db4587..e5669a69858a12cf0470be2c53dced15f389766f 100644
--- a/components/offline_pages/background/request_queue_in_memory_store.h
+++ b/components/offline_pages/background/request_queue_in_memory_store.h
@@ -28,6 +28,8 @@ class RequestQueueInMemoryStore : public RequestQueueStore {
const UpdateCallback& callback) override;
void RemoveRequests(const std::vector<int64_t>& request_ids,
chili 2016/08/01 19:34:40 just out of curiosity - are there plans to expose
Pete Williamson 2016/08/01 23:23:08 It is already exposed, RemoveReqeusts removes them
const RemoveCallback& callback) override;
+ void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids,
+ const RemoveCallback& callback) override;
void Reset(const ResetCallback& callback) override;
private:

Powered by Google App Engine
This is Rietveld 408576698