Provide API in RequestCoordinator to remove results by client ID.

components/offline_pages/background/request_queue_in_memory_store.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_IN_MEMORY_STORE_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_IN_MEMORY_STORE_H_
 
 #include <stdint.h>
 
 #include <map>
 
 #include "base/macros.h"
 #include "components/offline_pages/background/request_queue_store.h"
 
 namespace offline_pages {
 
 class SavePageRequest;
 
 // Interface for classes storing save page requests.
 class RequestQueueInMemoryStore : public RequestQueueStore {
  public:
   RequestQueueInMemoryStore();
   ~RequestQueueInMemoryStore() override;
 
   // RequestQueueStore implementaiton.
   void GetRequests(const GetRequestsCallback& callback) override;
   void AddOrUpdateRequest(const SavePageRequest& request,
                           const UpdateCallback& callback) override;
   void RemoveRequests(const std::vector<int64_t>& request_ids,

[chili, 2016/08/01 19:34:40]

just out of curiosity - are there plans to expose 'remove requests by request
id' as well?

[Pete Williamson, 2016/08/01 23:23:08]

It is already exposed, RemoveReqeusts removes them by request id.
However, I am considering removing it in a future change, since we don't
actually use it.  It turns out that its utility is limited by the fact that the
request coordinator doesn't keep the request ids around, and its clients don't
use them either.

                       const RemoveCallback& callback) override;
+  void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids,
+                                const RemoveCallback& callback) override;
   void Reset(const ResetCallback& callback) override;
 
  private:
   typedef std::map<int64_t, SavePageRequest> RequestsMap;
   RequestsMap requests_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestQueueInMemoryStore);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_IN_MEMORY_STORE_H_