Fix isolate_tests/clean isolate step

Fix isolate_tests/clean isolate step

Add 'data' to copy() to for swarm-testing to work on trybots.
Otherwise, the ICU data bundle would not be copied in isolate_tests step and
all the tests requiring the ICU data would fail on trybots.

BUG=v8:4828
TEST=base_unittests and many other tests pass on trybots (with test isolation)
R=machenbach@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/ef5c735307d0f86c7622f69620994c9468beba99

[jungshik at Google, 2016-07-29 09:43:20]

Description was changed from

==========
Add 'data' to copy()

'data' seems to be necessary in 'copy()' for swarm-testing on trybot
to work.

BUG=
==========

to

==========
Fix isolate_tests/clean isolate step

Add 'data' to copy() to for swarm-testing to work on trybots.
Otherwise, the ICU data bundle would not be copied in isolate_tests step and
all the tests requiring the ICU data would fail on trybots.

BUG=v8:4828
TEST=base_unittests and many other tests pass on trybots (with test isolation)
==========

[jungshik at Google, 2016-07-29 10:38:47]

jshin@chromium.org changed reviewers:
+ machenbach@chromium.org

[jungshik at Google, 2016-07-29 10:38:48]

Can you take a look? 

I made a mistake of not including 'data' for 'copy()' action  in the previous GN
CL. This should fix trybot failures observed when rolling icu (
https://codereview.chromium.org/2188333002/ ). 

BTW, thanks again for enabling trybots for ICU. Otherwise, it'd be rather hard
to fix this issue.

[Michael Achenbach, 2016-07-29 11:44:37]

https://codereview.chromium.org/2197523002/diff/80001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2197523002/diff/80001/BUILD.gn#newcode599
BUILD.gn:599: if (big_endian) {
Not sure if I understand. Who consumes data? The copy template doesn't
understand the "data" variable according to doc:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

Or is the doc out-of-date?

[Michael Achenbach, 2016-07-29 11:45:46]

lgtm - stamp - since trybots seem to be happy

[jungshik at Google, 2016-07-29 16:28:51]

On 2016/07/29 11:44:37, Michael Achenbach (slow) wrote:
> https://codereview.chromium.org/2197523002/diff/80001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2197523002/diff/80001/BUILD.gn#newcode599
> BUILD.gn:599: if (big_endian) {
> Not sure if I understand. Who consumes data? The copy template doesn't
> understand the "data" variable according to doc:
>
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...
> 
> Or is the doc out-of-date?

Apparently, it's not saying everything I need to know about 'copy' action. When
I read the section on 'copy',
I was also puzzled by no mentioning of 'data' variable. 
'data' is apparently used in 'isolate_tests' and 'clean_isolate' step.
(especially, the former). If I put in "{{source_file_part}}' (expecting
it to be expanded to real file names), I got an error in 'isolate_tests' step
about unexisting file  '/path/to/buildroot/{{source_file_part}}'.

[jungshik at Google, 2016-07-29 16:29:11]

On 2016/07/29 11:45:46, Michael Achenbach (slow) wrote:
> lgtm - stamp - since trybots seem to be happy

THank you

[jungshik at Google, 2016-07-29 21:12:09]

Description was changed from

==========
Fix isolate_tests/clean isolate step

Add 'data' to copy() to for swarm-testing to work on trybots.
Otherwise, the ICU data bundle would not be copied in isolate_tests step and
all the tests requiring the ICU data would fail on trybots.

BUG=v8:4828
TEST=base_unittests and many other tests pass on trybots (with test isolation)
==========

to

==========
Fix isolate_tests/clean isolate step

Add 'data' to copy() to for swarm-testing to work on trybots.
Otherwise, the ICU data bundle would not be copied in isolate_tests step and
all the tests requiring the ICU data would fail on trybots.

BUG=v8:4828
TEST=base_unittests and many other tests pass on trybots (with test isolation)
R=machenbach@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/icu/+/ef5c735307d0f86c7622f69...
==========

[jungshik at Google, 2016-07-29 21:12:10]

Committed patchset #6 (id:100001) manually as
ef5c735307d0f86c7622f69620994c9468beba99 (presubmit successful).