Fix isolate_tests/clean isolate step

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/icu/config.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
@@ skipping 553 matching lines @@
     if (icu_use_data_file) {
       sources = [ "$root_out_dir/icudtl.dat" ]
       deps = [ ":icudata" ]
       disable_compression = true
     }
   }
 }
 
 # TODO(GYP): Gyp has considerations here for QNX and for the host toolchain
 #  that have not been ported over.
-data_bundle = "common/icudtl.dat"
+big_endian = false
+if (current_cpu == "mips" || current_cpu == "mips64") {
+  big_endian = true
+}
+
 if (is_android) {
   data_bundle = "android/icudtl.dat"
-} else if (current_cpu == "mips" || current_cpu == "mips64") {
+} else if (big_endian) {
   data_bundle = "common/icudtb.dat"
 } else {
   data_bundle = "common/icudtl.dat"
 }
 
 # TODO(GYP) support use_system_icu.
 if (icu_use_data_file) {
   if (is_ios) {
     bundle_data("icudata") {
       sources = [ "$data_bundle" ]
       outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
     }
   } else {
     copy("icudata") {
       sources = [ "$data_bundle" ]
       outputs = [ "$root_out_dir/{{source_file_part}}" ]
+      # {{source_file_part}} is not expanded in 'data'.
+      if (big_endian) {

[Michael Achenbach, 2016/07/29 11:44:37]

Not sure if I understand. Who consumes data? The copy template doesn't
understand the "data" variable according to doc:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

Or is the doc out-of-date?

+        data = [ "$root_out_dir/icudtb.dat" ]
+      } else {
+        data = [ "$root_out_dir/icudtl.dat" ]
+      }
     }
   }
 } else {
   if (is_win) {
     # On Windows the target DLL is pre-built so just use a copy rule.
     copy("icudata") {
       sources = [
         "windows/icudt.dll",
       ]
-      outputs = [
-        "$root_out_dir/icudt.dll",
-      ]
+      outputs = [ "$root_out_dir/icudt.dll" ]
+      data = outputs
     }
   } else {
-    if (current_cpu == "mips" || current_cpu == "mips64") {
+    if (big_endian) {
       data_assembly = "$target_gen_dir/icudtb_dat.S"
     } else {
       data_assembly = "$target_gen_dir/icudtl_dat.S"
     }
     action("make_data_assembly") {
       script = "scripts/make_data_assembly.py"
       inputs = [ "$data_bundle" ]
       outputs = [ "$data_assembly" ]
       args = [
         rebase_path(data_bundle, root_build_dir),
         rebase_path(data_assembly, root_build_dir),
       ]
       if (is_mac) {
         args += [ "--mac" ]
       }
     }
 
     source_set("icudata") {
       sources = [ "$data_assembly" ]
       defines = [ "U_HIDE_DATA_SYMBOL" ]
       deps = [ ":make_data_assembly", ]
     }
   }
 }