Use PaintOperation instead of bFillOrStroke in CPVT_GenerateAP.

Use PaintOperation instead of bFillOrStroke in CPVT_GenerateAP.
    
Also, use PaintOperation instead of bStrokingOperation in
CPDF_DefaultAppearance.

Committed: https://pdfium.googlesource.com/pdfium/+/b2e63373054f0f1c3dbcdfa5e75acf2831b113f6

[jaepark, 2016-08-01 18:18:57]

jaepark@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Lei Zhang, 2016-08-01 19:33:48]

https://codereview.chromium.org/2197353002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2197353002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:756: bool bIsStroke) {
Consider making this an enum, then you can write:

GenerateColorAP(color, kFill);
GenerateColorAP(color, kStroke);

and that's more readable than GenerateColorAP(color, true);  // what does true
mean again?

[jaepark, 2016-08-02 18:15:47]

https://codereview.chromium.org/2197353002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2197353002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:756: bool bIsStroke) {
On 2016/08/01 19:33:48, Lei Zhang wrote:
> Consider making this an enum, then you can write:
> 
> GenerateColorAP(color, kFill);
> GenerateColorAP(color, kStroke);
> 
> and that's more readable than GenerateColorAP(color, true);  // what does true
> mean again?

Done.

[Lei Zhang, 2016-08-02 18:52:51]

lgtm, but the CL description is out of date.

https://codereview.chromium.org/2197353002/diff/20001/core/fpdfdoc/include/cp...
File core/fpdfdoc/include/cpdf_defaultappearance.h (right):

https://codereview.chromium.org/2197353002/diff/20001/core/fpdfdoc/include/cp...
core/fpdfdoc/include/cpdf_defaultappearance.h:17: enum class PaintOperation {
kStroke, kFill };
Sorry to give you slightly bad advice. Google style guide prefers kFoo, but
Chromium style guide prefers FOO. Dan also voted for the latter, and BorderStyle
above is also SHOUTY_CASE. So can we do one more round of search+replace and git
cl format?

[jaepark, 2016-08-02 19:04:13]

Description was changed from

==========
Rename bFillOrStroke to bIsStroke for CPVT_GenerateAP::GenerateColorAP
parameter.

Also change the parameter type from const FX_BOOL& to bool.
==========

to

==========
Use PaintOperation instead of bFillOrStroke in CPVT_GenerateAP.
    
Also, use PaintOperation instead of bStrokingOperation in
CPDF_DefaultAppearance.
==========

[jaepark, 2016-08-02 19:04:22]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:04:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 19:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:23:23]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-02 19:23:26]

https://codereview.chromium.org/2197353002/diff/20001/core/fpdfdoc/include/cp...
File core/fpdfdoc/include/cpdf_defaultappearance.h (right):

https://codereview.chromium.org/2197353002/diff/20001/core/fpdfdoc/include/cp...
core/fpdfdoc/include/cpdf_defaultappearance.h:17: enum class PaintOperation {
kStroke, kFill };
On 2016/08/02 18:52:51, Lei Zhang wrote:
> Sorry to give you slightly bad advice. Google style guide prefers kFoo, but
> Chromium style guide prefers FOO. Dan also voted for the latter, and
BorderStyle
> above is also SHOUTY_CASE. So can we do one more round of search+replace and
git
> cl format?

Done.

[Lei Zhang, 2016-08-02 19:24:27]

++lgtm

[jaepark, 2016-08-02 19:24:49]

The CQ bit was checked by jaepark@google.com

[commit-bot: I haz the power, 2016-08-02 19:24:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 19:25:18]

Description was changed from

==========
Use PaintOperation instead of bFillOrStroke in CPVT_GenerateAP.
    
Also, use PaintOperation instead of bStrokingOperation in
CPDF_DefaultAppearance.
==========

to

==========
Use PaintOperation instead of bFillOrStroke in CPVT_GenerateAP.
    
Also, use PaintOperation instead of bStrokingOperation in
CPDF_DefaultAppearance.

Committed:
https://pdfium.googlesource.com/pdfium/+/b2e63373054f0f1c3dbcdfa5e75acf2831b1...
==========

[commit-bot: I haz the power, 2016-08-02 19:25:19]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b2e63373054f0f1c3dbcdfa5e75acf2831b1...