Use PaintOperation instead of bFillOrStroke in CPVT_GenerateAP.

core/fpdfdoc/include/cpdf_defaultappearance.h

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_FPDFDOC_INCLUDE_CPDF_DEFAULTAPPEARANCE_H_
 #define CORE_FPDFDOC_INCLUDE_CPDF_DEFAULTAPPEARANCE_H_
 
 #include "core/fpdfdoc/include/cpdf_defaultappearance.h"
 #include "core/fxcrt/include/fx_coordinates.h"
 #include "core/fxcrt/include/fx_string.h"
 #include "core/fxcrt/include/fx_system.h"
 #include "core/fxge/include/fx_dib.h"
 
 enum class BorderStyle { SOLID, DASH, BEVELED, INSET, UNDERLINE };
+enum class PaintOperation { kStroke, kFill };

[Lei Zhang, 2016/08/02 18:52:51]

Sorry to give you slightly bad advice. Google style guide prefers kFoo, but
Chromium style guide prefers FOO. Dan also voted for the latter, and BorderStyle
above is also SHOUTY_CASE. So can we do one more round of search+replace and git
cl format?

[jaepark, 2016/08/02 19:23:26]

Done.

 
 class CPDF_DefaultAppearance {
  public:
   CPDF_DefaultAppearance() {}
   explicit CPDF_DefaultAppearance(const CFX_ByteString& csDA) : m_csDA(csDA) {}
 
   CPDF_DefaultAppearance(const CPDF_DefaultAppearance& cDA) {
     m_csDA = cDA.GetStr();
   }
 
   CFX_ByteString GetStr() const { return m_csDA; }
 
   FX_BOOL HasFont();
   CFX_ByteString GetFontString();
   void GetFont(CFX_ByteString& csFontNameTag, FX_FLOAT& fFontSize);
 
-  FX_BOOL HasColor(FX_BOOL bStrokingOperation = FALSE);
-  CFX_ByteString GetColorString(FX_BOOL bStrokingOperation = FALSE);
+  FX_BOOL HasColor(PaintOperation nOperation = PaintOperation::kFill);
+  CFX_ByteString GetColorString(
+      PaintOperation nOperation = PaintOperation::kFill);
   void GetColor(int& iColorType,
                 FX_FLOAT fc[4],
-                FX_BOOL bStrokingOperation = FALSE);
+                PaintOperation nOperation = PaintOperation::kFill);
   void GetColor(FX_ARGB& color,
                 int& iColorType,
-                FX_BOOL bStrokingOperation = FALSE);
+                PaintOperation nOperation = PaintOperation::kFill);
 
   FX_BOOL HasTextMatrix();
   CFX_ByteString GetTextMatrixString();
   CFX_Matrix GetTextMatrix();
 
  private:
   CFX_ByteString m_csDA;
 };
 
 #endif  // CORE_FPDFDOC_INCLUDE_CPDF_DEFAULTAPPEARANCE_H_