Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2197323002: implement isABitmap for imageshader, return localmatrix for bitmap's impl (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

implement isABitmap for imageshader, return localmatrix for bitmap's impl For imageshader, I only return true if the image is explicitly raster-backed. I do not return true for texture, nor for generator (i.e. lazy/picture) backed. Is that ok? BUG=skia:5592 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197323002 Committed: https://skia.googlesource.com/skia/+/f1ac18229c3f0f813a128a10111766c991f9dfcf

Patch Set 1 #

Patch Set 2 : update pdf shader #

Patch Set 3 : add isAImage api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -5 lines) Patch
M include/core/SkShader.h View 1 2 3 chunks +17 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImageShader.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkImageShader.cpp View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
A tests/ShaderTest.cpp View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
reed1
4 years, 4 months ago (2016-08-01 17:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197323002/1
4 years, 4 months ago (2016-08-01 17:31:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/10226)
4 years, 4 months ago (2016-08-01 17:39:07 UTC) #10
reed1
update pdf code
4 years, 4 months ago (2016-08-01 17:40:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197323002/20001
4 years, 4 months ago (2016-08-01 17:40:18 UTC) #13
reed1
now with isAImage api
4 years, 4 months ago (2016-08-01 17:55:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197323002/40001
4 years, 4 months ago (2016-08-01 17:55:52 UTC) #18
hal.canary
lgtm
4 years, 4 months ago (2016-08-01 18:03:31 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 18:24:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f1ac18229c3f0f813a128a10111766c991f9dfcf

Powered by Google App Engine
This is Rietveld 408576698