SubZero: Adding support for all Reg pairs in getI64PairFirst/SecondGPRNum

SubZero: Adding support for all Reg pairs in getI64PairFirst/SecondGPRNum

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=eec5621da7af1b5934af015ec8b748eaa654f8ca

[mohit.bhakkad, 2016-08-01 14:50:48]

Description was changed from

==========
Adding support for all Reg pairs in getI64PairFirst/SecondGPRNum

BUG=
==========

to

==========
SubZero: Adding support for all Reg pairs in getI64PairFirst/SecondGPRNum
==========

[mohit.bhakkad, 2016-08-01 14:50:48]

mohit.bhakkad@imgtec.com changed reviewers:
+ eholk@chromium.org, jrg@chromium.org, kschimpf@google.com,
sagar.thakur@imgtec.com, srdjan.obucina@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2016-08-01 20:14:29]

https://codereview.chromium.org/2197233002/diff/1/src/IceRegistersMIPS32.h
File src/IceRegistersMIPS32.h (right):

https://codereview.chromium.org/2197233002/diff/1/src/IceRegistersMIPS32.h#ne...
src/IceRegistersMIPS32.h:93: assert(unsigned(RegNum) >= Reg_I64PAIR_First &&
Instead of:
  assert(a && b);
do:
  assert(a);
  assert(b);
in order to get better precision on an assertion failure.

(here and below)

https://codereview.chromium.org/2197233002/diff/1/src/IceRegistersMIPS32.h#ne...
src/IceRegistersMIPS32.h:99: else if (unsigned(RegNum) >= Reg_I64PAIR_First &&
change "else if" to "if" because of the unconditional return in the "if" branch.

(here and below)

[Jim Stichnoth, 2016-08-02 12:54:58]

lgtm

[Jim Stichnoth, 2016-08-02 12:55:16]

Description was changed from

==========
SubZero: Adding support for all Reg pairs in getI64PairFirst/SecondGPRNum
==========

to

==========
SubZero: Adding support for all Reg pairs in getI64PairFirst/SecondGPRNum

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-08-02 12:55:19]

Committed patchset #2 (id:20001) manually as
eec5621da7af1b5934af015ec8b748eaa654f8ca (presubmit successful).