Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2197233002: SubZero: Adding support for all Reg pairs in getI64PairFirst/SecondGPRNum (Closed)

Created:
4 years, 4 months ago by mohit.bhakkad
Modified:
4 years, 4 months ago
Reviewers:
Karl, John Grabowski, sagar.thakur, Jim Stichnoth, srdjan.obucina, Eric Holk
CC:
native-client-reviews_googlegroups.com, jaydeep.patil, rich.fuhler_imgtec.com, srdjan.obucina_imgtec.com, sagar.thakur
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M src/IceRegistersMIPS32.h View 1 1 chunk +24 lines, -14 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mohit.bhakkad
4 years, 4 months ago (2016-08-01 14:51:26 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/2197233002/diff/1/src/IceRegistersMIPS32.h File src/IceRegistersMIPS32.h (right): https://codereview.chromium.org/2197233002/diff/1/src/IceRegistersMIPS32.h#newcode93 src/IceRegistersMIPS32.h:93: assert(unsigned(RegNum) >= Reg_I64PAIR_First && Instead of: assert(a && b); ...
4 years, 4 months ago (2016-08-01 20:14:29 UTC) #4
mohit.bhakkad
4 years, 4 months ago (2016-08-02 06:40:37 UTC) #5
Jim Stichnoth
lgtm
4 years, 4 months ago (2016-08-02 12:54:58 UTC) #6
Jim Stichnoth
4 years, 4 months ago (2016-08-02 12:55:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eec5621da7af1b5934af015ec8b748eaa654f8ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698