Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2197223002: Use base::string16 for user-visible texts in ContentSuggestion (Closed)

Created:
4 years, 4 months ago by Philipp Keck
Modified:
4 years, 4 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::string16 for user-visible texts in ContentSuggestion Because some providers (like the bookmarks provider) have their strings available in UTF-16 encoding, we should use these throughout. The NTPSnippetsService needs to continue using std::string because the JSON format does not support UTF-16. BUG=633141 Committed: https://crrev.com/fec302508285401ac5a98f8d9391b22e833ad52f Cr-Commit-Position: refs/heads/master@{#408971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M components/ntp_snippets/content_suggestion.h View 4 chunks +10 lines, -9 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Philipp Keck
4 years, 4 months ago (2016-08-01 14:24:24 UTC) #2
Marc Treib
lgtm
4 years, 4 months ago (2016-08-01 14:30:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197223002/1
4 years, 4 months ago (2016-08-01 14:58:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 15:54:48 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 15:58:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fec302508285401ac5a98f8d9391b22e833ad52f
Cr-Commit-Position: refs/heads/master@{#408971}

Powered by Google App Engine
This is Rietveld 408576698