components/ntp_snippets/ntp_snippets_service.cc - Issue 2197223002: Use base::string16 for user-visible texts in ContentSuggestion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2197223002: Use base::string16 for user-visible texts in ContentSuggestion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/content_suggestion.h ('k') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index 67a23d42f846dca69738bd9c9a1c4e6ba1f6ccbd..825de07f89ae8d900c5a7f625c97336a98a5a242 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -16,6 +16,7 @@

#include "base/metrics/sparse_histogram.h"

#include "base/path_service.h"

#include "base/strings/string_number_conversions.h"

+#include "base/strings/utf_string_conversions.h"

#include "base/task_runner_util.h"

#include "base/time/time.h"

#include "base/values.h"

@@ -788,10 +789,11 @@ void NTPSnippetsService::NotifyNewSuggestions() {

MakeUniqueID(provided_category_, snippet->id()),

snippet->best_source().url);

suggestion.set_amp_url(snippet->best_source().amp_url);

- suggestion.set_title(snippet->title());

- suggestion.set_snippet_text(snippet->snippet());

+ suggestion.set_title(base::UTF8ToUTF16(snippet->title()));

+ suggestion.set_snippet_text(base::UTF8ToUTF16(snippet->snippet()));

suggestion.set_publish_date(snippet->publish_date());

- suggestion.set_publisher_name(snippet->best_source().publisher_name);

+ suggestion.set_publisher_name(

+ base::UTF8ToUTF16(snippet->best_source().publisher_name));

suggestion.set_score(snippet->score());

result.emplace_back(std::move(suggestion));

}