tools/perf/benchmarks/page_cycler.py - Issue 2197213003: Disable page_cycler.top_10_mobile on Nexus 5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 2197213003: Disable page_cycler.top_10_mobile on Nexus 5. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/page_cycler.py

diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py

index fb9c5c18624f12b3f57853b34e254d6984b6a0e0..682e218b0421aa4d8f6f565b06c562fdbb36bb79 100644

--- a/tools/perf/benchmarks/page_cycler.py

+++ b/tools/perf/benchmarks/page_cycler.py

@@ -86,6 +86,11 @@ class PageCyclerTop10Mobile(_PageCycler):

stories.RemoveStory(found)

return stories

+ @classmethod

+ def ShouldDisable(cls, possible_browser):

+ # http://crbug.com/633222 (Android Nexus 5).

+ return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5'

@benchmark.Disabled('android') # crbug.com/357326

class PageCyclerToughLayoutCases(_PageCycler):

« no previous file with comments | « no previous file | no next file » | no next file with comments »