Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: tools/perf/benchmarks/page_cycler.py

Issue 2197213003: Disable page_cycler.top_10_mobile on Nexus 5. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from measurements import page_cycler 7 from measurements import page_cycler
8 import page_sets 8 import page_sets
9 from telemetry import benchmark 9 from telemetry import benchmark
10 10
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 return 'page_cycler.top_10_mobile' 79 return 'page_cycler.top_10_mobile'
80 80
81 def CreateStorySet(self, options): 81 def CreateStorySet(self, options):
82 # Disable the taobao.com page since it's crashing. crbug.com/509690 82 # Disable the taobao.com page since it's crashing. crbug.com/509690
83 stories = page_sets.Top10MobilePageSet(run_no_page_interactions=True) 83 stories = page_sets.Top10MobilePageSet(run_no_page_interactions=True)
84 found = next((x for x in stories if 'taobao.com' in x.url), None) 84 found = next((x for x in stories if 'taobao.com' in x.url), None)
85 if found: 85 if found:
86 stories.RemoveStory(found) 86 stories.RemoveStory(found)
87 return stories 87 return stories
88 88
89 @classmethod
90 def ShouldDisable(cls, possible_browser):
91 # http://crbug.com/633222 (Android Nexus 5).
92 return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5'
93
89 94
90 @benchmark.Disabled('android') # crbug.com/357326 95 @benchmark.Disabled('android') # crbug.com/357326
91 class PageCyclerToughLayoutCases(_PageCycler): 96 class PageCyclerToughLayoutCases(_PageCycler):
92 """Page loading for the slowest layouts observed in the Alexa top 1 million. 97 """Page loading for the slowest layouts observed in the Alexa top 1 million.
93 98
94 Recorded in July 2013. 99 Recorded in July 2013.
95 """ 100 """
96 page_set = page_sets.ToughLayoutCasesPageSet 101 page_set = page_sets.ToughLayoutCasesPageSet
97 102
98 @classmethod 103 @classmethod
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 set, without running in out-of-process iframes mode.. """ 149 set, without running in out-of-process iframes mode.. """
145 page_set = page_sets.OopifBasicPageSet 150 page_set = page_sets.OopifBasicPageSet
146 151
147 @classmethod 152 @classmethod
148 def Name(cls): 153 def Name(cls):
149 return 'page_cycler.basic_oopif' 154 return 'page_cycler.basic_oopif'
150 155
151 @classmethod 156 @classmethod
152 def ShouldDisable(cls, possible_browser): 157 def ShouldDisable(cls, possible_browser):
153 return cls.IsSvelte(possible_browser) # http://crbug.com/607657 158 return cls.IsSvelte(possible_browser) # http://crbug.com/607657
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698