Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2197213002: Fix layout test accessibility/misspelling.html (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
nektarios, yosin_UTC9
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout test accessibility/misspelling.html This patch modifies the layout test in the following ways: 1. Add more step_timeout() to ensure that a test can be run only after all previous tests are done. 2. In the second test case, ensure the triggering of spell checking by moving the caret into <p>. BUG=619452 TEST=n/a; this patch changes a test file R=nektar@chromium.org, yosin@chromium.org Committed: https://crrev.com/4282ab146912a47641e62be16518fcd739f1c801 Cr-Commit-Position: refs/heads/master@{#409118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -51 lines) Patch
M third_party/WebKit/LayoutTests/accessibility/misspellings.html View 1 chunk +59 lines, -51 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Xiaocheng
PTAL? I'm modifying this layout test because it's blocking an on-going refactoring [1]. It fails ...
4 years, 4 months ago (2016-08-01 15:09:46 UTC) #5
nektarios
+ step_timeout(function() { + document.designMode = 'on'; Please move "{" to the next line.
4 years, 4 months ago (2016-08-01 15:20:33 UTC) #7
nektarios
lgtm
4 years, 4 months ago (2016-08-01 15:20:43 UTC) #8
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-02 01:31:12 UTC) #9
Xiaocheng
Thanks for your review.
4 years, 4 months ago (2016-08-02 01:32:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197213002/1
4 years, 4 months ago (2016-08-02 01:32:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 01:35:38 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 01:38:05 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4282ab146912a47641e62be16518fcd739f1c801
Cr-Commit-Position: refs/heads/master@{#409118}

Powered by Google App Engine
This is Rietveld 408576698