Always local fallback for message_names.cc

Always local fallback for message_names.cc

On Mac, compile for tools/ipc_fuzzer/message_lib/message_names.cc is
always time out with goma.

If compile takes more than 10 minutes on goma executor, goma returns
error because of timeout. The compile for this file always spends more
than 10 minutes to wait for response from goma server, and it's re-run
locally after the timeout.

Let's make it local fallback always to make build faster.

BUG=630502
Committed: https://chromium.googlesource.com/chromium/tools/build/+/fbd5dc3864acb34635f84586470c14cc06cf09d9

[shinyak, 2016-08-01 08:21:37]

shinyak@chromium.org changed reviewers:
+ tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org

[tikuta, 2016-08-01 08:39:29]

lgtm

https://codereview.chromium.org/2197083002/diff/20001/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2197083002/diff/20001/scripts/slave/compile.p...
scripts/slave/compile.py:116: env['GOMA_FALLBACK_INPUT_FILES'] = (
Is it not good to set this variable only for mac builder?

[shinyak, 2016-08-01 08:54:00]

PTAL

https://codereview.chromium.org/2197083002/diff/20001/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2197083002/diff/20001/scripts/slave/compile.p...
scripts/slave/compile.py:116: env['GOMA_FALLBACK_INPUT_FILES'] = (
Added chromium_utils.IsMac().

[tikuta, 2016-08-01 08:55:09]

lgtm

[Yoshisato Yanagisawa, 2016-08-01 09:42:51]

lgtm w/ nit.

https://codereview.chromium.org/2197083002/diff/40001/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2197083002/diff/40001/scripts/slave/compile.p...
scripts/slave/compile.py:113: # Workaround for crbug.com/630502. Compiling
maybe HACK?

[shinyak (Google), 2016-08-01 09:52:50]

shinyak@google.com changed reviewers:
+ shinyak@google.com

[shinyak (Google), 2016-08-01 09:52:50]

https://codereview.chromium.org/2197083002/diff/40001/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2197083002/diff/40001/scripts/slave/compile.p...
scripts/slave/compile.py:113: # Workaround for crbug.com/630502. Compiling
On 2016/08/01 09:42:50, Yoshisato Yanagisawa wrote:
> maybe HACK?

Done.

[ukai, 2016-08-02 01:27:15]

lgtm

[shinyak, 2016-08-02 02:19:24]

The CQ bit was checked by shinyak@chromium.org

[shinyak, 2016-08-02 02:19:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
yyanagisawa@chromium.org, tikuta@chromium.org
Link to the patchset: https://codereview.chromium.org/2197083002/#ps60001
(title: "Add HACK")

[commit-bot: I haz the power, 2016-08-02 02:19:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 02:23:51]

Description was changed from

==========
Always local fallback for message_names.cc

On Mac, compile for tools/ipc_fuzzer/message_lib/message_names.cc is
always time out with goma.

If compile takes more than 10 minutes on goma executor, goma returns
error because of timeout. The compile for this file always spends more
than 10 minutes to wait for response from goma server, and it's re-run
locally after the timeout.

Let's make it local fallback always to make build faster.

BUG=630502
==========

to

==========
Always local fallback for message_names.cc

On Mac, compile for tools/ipc_fuzzer/message_lib/message_names.cc is
always time out with goma.

If compile takes more than 10 minutes on goma executor, goma returns
error because of timeout. The compile for this file always spends more
than 10 minutes to wait for response from goma server, and it's re-run
locally after the timeout.

Let's make it local fallback always to make build faster.

BUG=630502

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/fbd5dc3864acb34635f8...
==========

[commit-bot: I haz the power, 2016-08-02 02:23:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/fbd5dc3864acb34635f8...

[Nico, 2016-08-04 18:57:03]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-08-04 18:57:04]

I think this should be reverted. It didn't help, and as of
https://codereview.chromium.org/2214713003 the file is much faster to compile.

[shinyak, 2016-08-08 01:32:54]

Great, it's a good news!

[shinyak, 2016-08-08 01:33:28]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2220883002/ by shinyak@chromium.org.

The reason for reverting is: No need to do workaround thanks to
https://codereview.chromium.org/2214713003.