Updating Security Key logic to work on OSX

Updating Security Key logic to work on macOS

Since macOS supports UDS we can reuse much on the Linux SK classes for macOS.
This change updates the build macros to include SK functionality in macOS
builds and passes in an ssh-auth-sock socket path based on the user name.
These changes allow the Host to indicate that they support SK forwarding when
the client connects.

Note that the SK socket is not created until a user connects.  This means we
want to scope the lifetime of the socket to a Chromoting session.  The SK socket
class was initially used in our virtual Linux session which was created
specifically for our use and could live 'forever'.  Since this is not the case
for macOS, and the extended lifetime is not a benefit for Linux, I have added
code to clean up the socket when the session ends.

BUG=633025
Committed: https://crrev.com/c0e8b3411d0fae9f3cb0e60f5918778c2e464376
Cr-Commit-Position: refs/heads/master@{#429293}

[joedow, 2016-08-01 03:35:05]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 03:35:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 04:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 04:02:00]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[joedow, 2016-08-01 22:18:14]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 22:18:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:21:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:21:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[joedow, 2016-08-01 22:55:20]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 22:55:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 00:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 00:03:47]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-10-31 22:05:57]

Patchset #3 (id:40001) has been deleted

[joedow, 2016-10-31 22:06:06]

Patchset #2 (id:20001) has been deleted

[joedow, 2016-10-31 22:18:36]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 22:19:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-10-31 22:50:53]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 22:51:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-10-31 23:00:40]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-10-31 23:00:41]

PTAL!

[commit-bot: I haz the power, 2016-10-31 23:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:49:35]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-11-01 17:00:09]

Couple nits about CL description:
 1. Please add more details, see
https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list...
 2. OSX is macOS now

Otherwise LGTM

[joedow, 2016-11-02 15:44:31]

Description was changed from

==========
Updating Security Key logic to work on OSX

BUG=633025
==========

to

==========
Updating Security Key logic to work on OSX

Since OSX supports UDS we can reuse much on the Linux SK classes for OSX.  This
change
updates the build macros to include SK functionality in OSX builds and passes in
an
ssh-auth-sock socket path based on the user name.  These changes allow the Host
to
indicate that they support SK forwarding when the client connects.

Note that the SK socket is not created until a user connects.  This means we
want to
scope the lifetime of the socket to a Chromoting session.  The SK socket class
was
initially used in our virtual Linux session which was created specifically for
our
use and could live 'forever'.  Since this is not the case for OSX, and the
extended
lifetime is not a benefit for Linux, I have added code to clean up the socket
when
the session ends.

BUG=633025
==========

[joedow, 2016-11-02 15:46:17]

Description was changed from

==========
Updating Security Key logic to work on OSX

Since OSX supports UDS we can reuse much on the Linux SK classes for OSX.  This
change
updates the build macros to include SK functionality in OSX builds and passes in
an
ssh-auth-sock socket path based on the user name.  These changes allow the Host
to
indicate that they support SK forwarding when the client connects.

Note that the SK socket is not created until a user connects.  This means we
want to
scope the lifetime of the socket to a Chromoting session.  The SK socket class
was
initially used in our virtual Linux session which was created specifically for
our
use and could live 'forever'.  Since this is not the case for OSX, and the
extended
lifetime is not a benefit for Linux, I have added code to clean up the socket
when
the session ends.

BUG=633025
==========

to

==========
Updating Security Key logic to work on macOS

Since macOS supports UDS we can reuse much on the Linux SK classes for macOS.
This change updates the build macros to include SK functionality in macOS
builds and passes in an ssh-auth-sock socket path based on the user name.
These changes allow the Host to indicate that they support SK forwarding when
the client connects.

Note that the SK socket is not created until a user connects.  This means we
want to scope the lifetime of the socket to a Chromoting session.  The SK socket
class was initially used in our virtual Linux session which was created
specifically for our use and could live 'forever'.  Since this is not the case
for macOS, and the extended lifetime is not a benefit for Linux, I have added
code to clean up the socket when the session ends.

BUG=633025
==========

[joedow, 2016-11-02 15:47:11]

Sorry about the CL description, I updated it in my local commit but forget it
was not updated automatically in this CR system.

Thanks for the review!

[joedow, 2016-11-02 15:47:23]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-11-02 15:47:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 16:14:43]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-11-02 16:20:49]

Description was changed from

==========
Updating Security Key logic to work on macOS

Since macOS supports UDS we can reuse much on the Linux SK classes for macOS.
This change updates the build macros to include SK functionality in macOS
builds and passes in an ssh-auth-sock socket path based on the user name.
These changes allow the Host to indicate that they support SK forwarding when
the client connects.

Note that the SK socket is not created until a user connects.  This means we
want to scope the lifetime of the socket to a Chromoting session.  The SK socket
class was initially used in our virtual Linux session which was created
specifically for our use and could live 'forever'.  Since this is not the case
for macOS, and the extended lifetime is not a benefit for Linux, I have added
code to clean up the socket when the session ends.

BUG=633025
==========

to

==========
Updating Security Key logic to work on macOS

Since macOS supports UDS we can reuse much on the Linux SK classes for macOS.
This change updates the build macros to include SK functionality in macOS
builds and passes in an ssh-auth-sock socket path based on the user name.
These changes allow the Host to indicate that they support SK forwarding when
the client connects.

Note that the SK socket is not created until a user connects.  This means we
want to scope the lifetime of the socket to a Chromoting session.  The SK socket
class was initially used in our virtual Linux session which was created
specifically for our use and could live 'forever'.  Since this is not the case
for macOS, and the extended lifetime is not a benefit for Linux, I have added
code to clean up the socket when the session ends.

BUG=633025

Committed: https://crrev.com/c0e8b3411d0fae9f3cb0e60f5918778c2e464376
Cr-Commit-Position: refs/heads/master@{#429293}
==========

[commit-bot: I haz the power, 2016-11-02 16:20:51]

Patchset 4 (id:??) landed as
https://crrev.com/c0e8b3411d0fae9f3cb0e60f5918778c2e464376
Cr-Commit-Position: refs/heads/master@{#429293}