Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: remoting/host/remoting_me2me_host.cc

Issue 2197023002: Updating Security Key logic to work on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@posix_auth
Patch Set: Defaulting SK support to true since all hosts support it Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/remoting_me2me_host.cc
diff --git a/remoting/host/remoting_me2me_host.cc b/remoting/host/remoting_me2me_host.cc
index 32bf2e95c597add936ea8e36c73bdf5a16f49562..4b931866fb5d2ab66c6c09b55f39ee210a1778d7 100644
--- a/remoting/host/remoting_me2me_host.cc
+++ b/remoting/host/remoting_me2me_host.cc
@@ -152,11 +152,13 @@ const char kStdinConfigPath[] = "-";
// The command line switch used to pass name of the pipe to capture audio on
// linux.
const char kAudioPipeSwitchName[] = "audio-pipe-name";
+#endif // defined(OS_LINUX)
+#if defined(OS_POSIX)
// The command line switch used to pass name of the unix domain socket used to
// listen for security key requests.
const char kAuthSocknameSwitchName[] = "ssh-auth-sockname";
-#endif // defined(OS_LINUX)
+#endif // defined(OS_POSIX)
// The command line switch used by the parent to request the host to signal it
// when it is successfully started.
@@ -378,7 +380,7 @@ class HostProcess : public ConfigWatcher::Delegate,
bool curtain_required_ = false;
ThirdPartyAuthConfig third_party_auth_config_;
bool security_key_auth_policy_enabled_ = false;
- bool security_key_extension_supported_ = false;
+ bool security_key_extension_supported_ = true;
// Boolean to change flow, where necessary, if we're
// capturing a window instead of the entire desktop.
@@ -812,19 +814,19 @@ void HostProcess::StartOnUiThread() {
remoting::AudioCapturerLinux::InitializePipeReader(
context_->audio_task_runner(), audio_pipe_name);
}
+#endif // defined(OS_LINUX)
+#if defined(OS_POSIX)
base::FilePath security_key_socket_name =
base::CommandLine::ForCurrentProcess()->GetSwitchValuePath(
kAuthSocknameSwitchName);
if (!security_key_socket_name.empty()) {
remoting::SecurityKeyAuthHandler::SetSecurityKeySocketName(
security_key_socket_name);
- security_key_extension_supported_ = true;
+ } else {
+ security_key_extension_supported_ = false;
}
-#elif defined(OS_WIN)
- // TODO(joedow): Remove the conditional once this is supported on OSX.
- security_key_extension_supported_ = true;
-#endif // defined(OS_WIN)
+#endif // defined(OS_POSIX)
// Create a desktop environment factory appropriate to the build type &
// platform.
@@ -1243,7 +1245,7 @@ bool HostProcess::OnCurtainPolicyUpdate(base::DictionaryValue* policies) {
// TODO(jamiewalch): Fix this once we have implemented the multi-process
// daemon architecture (crbug.com/134894)
if (getuid() == 0) {
- LOG(ERROR) << "Running the host in the console login session is yet not "
+ LOG(ERROR) << "Running the host in the console login session is not yet "
"supported.";
ShutdownHost(kLoginScreenNotSupportedExitCode);
return false;

Powered by Google App Engine
This is Rietveld 408576698