Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 2196843003: Blink ServiceRegistry -> InterfaceProvider (Closed)

Created:
4 years, 4 months ago by Ben Goodger (Google)
Modified:
4 years, 4 months ago
Reviewers:
haraken, esprehn
CC:
Aaron Boodman, abarth-chromium, ajuma+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), haraken, jam, jbroman, Justin Novosad, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, pdr+graphicswatchlist_chromium.org, Peter Beverloo, qsr+mojo_chromium.org, rwlbuis, Stephen Chennney, timvolodine, toyoshim+midi_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Mojo) Shell types have been renamed elsewhere in Chromium, specifically ServiceRegistry is split into two parts: - InterfaceRegistry, for registration of interface factories in code that implements the interfaces - InterfaceProvider, allowing binding of named interfaces in code that consumes them. This reflects this naming scheme into Blink, which uses only the Provider half. R=esprehn@chromium.org http://crbug.com/632874 Committed: https://crrev.com/88716146562575803c737c1fad994413eb2b7fbb Cr-Commit-Position: refs/heads/master@{#408810}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -228 lines) Patch
M content/content_renderer.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
A content/renderer/mojo/blink_interface_provider_impl.h View 1 chunk +48 lines, -0 lines 0 comments Download
A + content/renderer/mojo/blink_interface_provider_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D content/renderer/mojo/blink_service_registry_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/renderer/mojo/blink_service_registry_impl.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 6 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationManager.cpp View 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/ServiceRegistry.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridgeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/public/platform/InterfaceProvider.h View 1 2 1 chunk +32 lines, -0 lines 1 comment Download
M third_party/WebKit/public/platform/Platform.h View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/public/platform/ServiceRegistry.h View 1 chunk +0 lines, -32 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (22 generated)
Ben Goodger (Google)
4 years, 4 months ago (2016-07-29 23:25:12 UTC) #15
esprehn
lgtm
4 years, 4 months ago (2016-07-29 23:51:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196843003/60001
4 years, 4 months ago (2016-07-29 23:56:56 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-30 00:03:24 UTC) #24
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/88716146562575803c737c1fad994413eb2b7fbb Cr-Commit-Position: refs/heads/master@{#408810}
4 years, 4 months ago (2016-07-30 00:05:44 UTC) #26
haraken
4 years, 4 months ago (2016-07-30 15:39:06 UTC) #28
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/2196843003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
(right):

https://codereview.chromium.org/2196843003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/notifications/NotificationManager.cpp:38:
Platform::current()->interfaceProvider()->getInterface(mojo::GetProxy(&m_service));

Not directly related to this CL, should we try to replace the per-platform
interface provider with per-frame interface provider?

https://codereview.chromium.org/2196843003/diff/60001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/InterfaceProvider.h (right):

https://codereview.chromium.org/2196843003/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/InterfaceProvider.h:16: // that would have
been necesary with shell::InterfaceProvider.

necessary

Powered by Google App Engine
This is Rietveld 408576698