third_party/WebKit/Source/modules/notifications/NotificationManager.cpp - Issue 2196843003: Blink ServiceRegistry -> InterfaceProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

Issue 2196843003: Blink ServiceRegistry -> InterfaceProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/nfc/NFC.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | third_party/WebKit/public/platform/InterfaceProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp b/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

index 9bda0a1f198ef6ca8c2c08a2ae129fa87927987b..ea8a6f7de4d7595c2eb417e7e9b6d32d8583342b 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

@@ -5,8 +5,8 @@

#include "modules/notifications/NotificationManager.h"

#include "platform/weborigin/SecurityOrigin.h"

+#include "public/platform/InterfaceProvider.h"

#include "public/platform/Platform.h"

-#include "public/platform/ServiceRegistry.h"

#include "public/platform/modules/permissions/permission_status.mojom-blink.h"

namespace blink {

@@ -35,7 +35,7 @@ const char* NotificationManager::supplementName()

NotificationManager::NotificationManager(ExecutionContext* executionContext)

: ContextLifecycleObserver(executionContext)

{

- Platform::current()->serviceRegistry()->connectToRemoteService(mojo::GetProxy(&m_service));

+ Platform::current()->interfaceProvider()->getInterface(mojo::GetProxy(&m_service));

haraken 2016/07/30 15:39:06 Not directly related to this CL, should we try to

}

NotificationManager::~NotificationManager()