Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: runtime/vm/code_generator.cc

Issue 2196723002: Refactor how we report reload results (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweak Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc
index b0b3a9c14df259a671d84fe1de55d7edb8ea5701..bc9689c2fe3bb0ad5daa9d5785f86ac52aa31c43 100644
--- a/runtime/vm/code_generator.cc
+++ b/runtime/vm/code_generator.cc
@@ -1357,13 +1357,13 @@ DEFINE_RUNTIME_ENTRY(StackOverflow, 0) {
}
if (do_reload) {
#ifndef PRODUCT
+ JSONStream js;
// Maybe adjust the rate of future reloads.
isolate->MaybeIncreaseReloadEveryNStackOverflowChecks();
// Issue a reload.
- isolate->ReloadSources(true /* force_reload */);
- const Error& error = Error::Handle(isolate->sticky_reload_error());
- if (!error.IsNull()) {
- FATAL1("*** Isolate reload failed: %s\n", error.ToErrorCString());
+ bool success = isolate->ReloadSources(&js, true /* force_reload */);
+ if (!success) {
+ FATAL1("*** Isolate reload failed:\n%s\n", js.ToCString());
}
#endif
}
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698