Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: runtime/vm/isolate.h

Issue 2196723002: Refactor how we report reload results (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweak Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 9c55cf3f9d745d06b5e53819cc902f629ef0834e..ed0c5b9f562d77618ebb567f3e5f41e20205b079 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -249,7 +249,8 @@ class Isolate : public BaseIsolate {
// By default the reload context is deleted. This parameter allows
// the caller to delete is separately if it is still needed.
- void ReloadSources(bool force_reload,
+ bool ReloadSources(JSONStream* js,
+ bool force_reload,
bool dont_delete_reload_context = false);
bool MakeRunnable();
@@ -539,9 +540,6 @@ class Isolate : public BaseIsolate {
RawError* sticky_error() const { return sticky_error_; }
void clear_sticky_error();
- RawError* sticky_reload_error() const { return sticky_reload_error_; }
- void clear_sticky_reload_error();
-
bool compilation_allowed() const { return compilation_allowed_; }
void set_compilation_allowed(bool allowed) {
compilation_allowed_ = allowed;
@@ -771,8 +769,6 @@ class Isolate : public BaseIsolate {
RawError* sticky_error_;
- RawError* sticky_reload_error_;
-
// Background compilation.
BackgroundCompiler* background_compiler_;
intptr_t background_compiler_disabled_depth_;
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698