Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2196723002: Refactor how we report reload results (Closed)

Created:
4 years, 4 months ago by Cutch
Modified:
4 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor how we report reload results - [x] Give the IsolateReloadContext a JSONStream. - [x] Remove the sticky reload error from the isolate. - [x] Print all reasons for cancelling when we fail. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/501c9896c19a4b2ee5944121c202ad3d78df7a87

Patch Set 1 #

Patch Set 2 : wip #

Total comments: 3

Patch Set 3 : turnidge review #

Patch Set 4 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -63 lines) Patch
M runtime/vm/code_generator.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 1 3 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/isolate.cc View 1 5 chunks +6 lines, -18 lines 0 comments Download
M runtime/vm/isolate_reload.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/isolate_reload.cc View 1 2 3 4 chunks +33 lines, -22 lines 0 comments Download
M runtime/vm/object_reload.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 1 chunk +1 line, -11 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
4 years, 4 months ago (2016-07-29 19:37:17 UTC) #3
turnidge
lgtm https://codereview.chromium.org/2196723002/diff/20001/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2196723002/diff/20001/runtime/vm/isolate_reload.cc#newcode550 runtime/vm/isolate_reload.cc:550: jsobj.AddProperty("type", "Reload"); ReloadReport or ReloadStatus. https://codereview.chromium.org/2196723002/diff/20001/runtime/vm/isolate_reload.cc#newcode553 runtime/vm/isolate_reload.cc:553: JSONArray ...
4 years, 4 months ago (2016-08-01 17:24:25 UTC) #4
Cutch
PTAL
4 years, 4 months ago (2016-08-01 17:56:48 UTC) #5
turnidge
lgtm
4 years, 4 months ago (2016-08-01 19:28:41 UTC) #6
Cutch
4 years, 4 months ago (2016-08-01 19:30:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
501c9896c19a4b2ee5944121c202ad3d78df7a87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698